From c8417540aca822a6c63b6ac61e681d929842c392 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 12:05:09 -0500 Subject: [PATCH 01/13] Modify pull request permissions in slash_clippy.yml Updated permissions for pull requests in the Clippy workflow and added job-specific permissions. --- .github/workflows/slash_clippy.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index e81d5a30..ce16ed3e 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -3,18 +3,25 @@ name: SlashClippy on: issue_comment: types: [created] - permissions: contents: write issues: write - pull-requests: read + pull-requests: write jobs: dispatch: if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '/clippy') }} runs-on: ubuntu-latest + + # job-specific permissions - required for reactions + permissions: + contents: write + issues: write + pull-requests: write + steps: - - uses: peter-evans/slash-command-dispatch@v4 + - name: Dispatch Clippy Command + uses: peter-evans/slash-command-dispatch@v4 with: token: ${{ secrets.GITHUB_TOKEN }} reaction-token: ${{ secrets.GITHUB_TOKEN }} @@ -22,3 +29,5 @@ jobs: dispatch-type: repository issue-type: pull-request repository: ${{ github.repository }} + # Conditionally enable reactions only if the PR is not from a fork to avoid run failures + reactions: ${{ github.event.issue.pull_request.head.repo.full_name == github.repository && 'eyes' || '' }} From aa4f3c53f3aa7932629bfef30b207ae856722b93 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 12:14:48 -0500 Subject: [PATCH 02/13] Update tokens for Clippy command dispatch --- .github/workflows/slash_clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index ce16ed3e..db443df0 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -23,8 +23,8 @@ jobs: - name: Dispatch Clippy Command uses: peter-evans/slash-command-dispatch@v4 with: - token: ${{ secrets.GITHUB_TOKEN }} - reaction-token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ secrets.SLASH_COMMAND_PAT }} + reaction-token: ${{ secrets.SLASH_COMMAND_PAT }} commands: clippy dispatch-type: repository issue-type: pull-request From 16d7827455d3ab3d395bb19aec7e54e4827e1453 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 12:24:21 -0500 Subject: [PATCH 03/13] Update token assignment in clippy.yml workflow update token --- .github/workflows/clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index b1756a9c..7196d1aa 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -22,8 +22,8 @@ jobs: - name: Set token id: token run: | - if [ -n "${{ secrets.REPO_SCOPED_TOKEN }}" ]; then - echo "token=${{ secrets.REPO_SCOPED_TOKEN }}" >> "$GITHUB_OUTPUT" + if [ -n "${{ secrets.SLASH_COMMAND_PAT }}" ]; then + echo "token=${{ secrets.SLASH_COMMAND_PAT }}" >> "$GITHUB_OUTPUT" else echo "token=${{ secrets.GITHUB_TOKEN }}" >> "$GITHUB_OUTPUT" fi From a8d4de3fae354b7ccd588599ae37b2db6517d668 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 12:29:00 -0500 Subject: [PATCH 04/13] Update repository reference in slash_clippy.yml changed repo name --- .github/workflows/slash_clippy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index db443df0..8846e467 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -28,6 +28,6 @@ jobs: commands: clippy dispatch-type: repository issue-type: pull-request - repository: ${{ github.repository }} + repository: ${{ github.event.issue.pull_request.base.repo.full_name }} # Conditionally enable reactions only if the PR is not from a fork to avoid run failures reactions: ${{ github.event.issue.pull_request.head.repo.full_name == github.repository && 'eyes' || '' }} From 7c8c1bf575f763e7455b0e5c2d7d17355b871c97 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 12:33:30 -0500 Subject: [PATCH 05/13] Revert token assignment in clippy.yml revert --- .github/workflows/clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index 7196d1aa..b1756a9c 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -22,8 +22,8 @@ jobs: - name: Set token id: token run: | - if [ -n "${{ secrets.SLASH_COMMAND_PAT }}" ]; then - echo "token=${{ secrets.SLASH_COMMAND_PAT }}" >> "$GITHUB_OUTPUT" + if [ -n "${{ secrets.REPO_SCOPED_TOKEN }}" ]; then + echo "token=${{ secrets.REPO_SCOPED_TOKEN }}" >> "$GITHUB_OUTPUT" else echo "token=${{ secrets.GITHUB_TOKEN }}" >> "$GITHUB_OUTPUT" fi From afa1fdfb872a4dabfbe02dc398fc81dc34172ccb Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 19:59:59 -0500 Subject: [PATCH 06/13] Change repository reference in slash_clippy.yml Updated the repository reference to use the current repository context. --- .github/workflows/slash_clippy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index 8846e467..db443df0 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -28,6 +28,6 @@ jobs: commands: clippy dispatch-type: repository issue-type: pull-request - repository: ${{ github.event.issue.pull_request.base.repo.full_name }} + repository: ${{ github.repository }} # Conditionally enable reactions only if the PR is not from a fork to avoid run failures reactions: ${{ github.event.issue.pull_request.head.repo.full_name == github.repository && 'eyes' || '' }} From c25ef1bc61d68413d6a964103282a0c06359af60 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:05:24 -0500 Subject: [PATCH 07/13] Update token retrieval in clippy.yml workflow --- .github/workflows/clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index b1756a9c..7196d1aa 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -22,8 +22,8 @@ jobs: - name: Set token id: token run: | - if [ -n "${{ secrets.REPO_SCOPED_TOKEN }}" ]; then - echo "token=${{ secrets.REPO_SCOPED_TOKEN }}" >> "$GITHUB_OUTPUT" + if [ -n "${{ secrets.SLASH_COMMAND_PAT }}" ]; then + echo "token=${{ secrets.SLASH_COMMAND_PAT }}" >> "$GITHUB_OUTPUT" else echo "token=${{ secrets.GITHUB_TOKEN }}" >> "$GITHUB_OUTPUT" fi From dceecce55f261ab89fe702001fd321c0bb71360e Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:11:54 -0500 Subject: [PATCH 08/13] Update reactions to always use 'eyes' Changed reactions configuration to always use 'eyes'. --- .github/workflows/slash_clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index db443df0..e74f20f8 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -29,5 +29,5 @@ jobs: dispatch-type: repository issue-type: pull-request repository: ${{ github.repository }} - # Conditionally enable reactions only if the PR is not from a fork to avoid run failures - reactions: ${{ github.event.issue.pull_request.head.repo.full_name == github.repository && 'eyes' || '' }} + # test without condition + reactions: eyes From d2bffaa31db975187eb5027a1ebbbe3bdefc30a9 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:25:14 -0500 Subject: [PATCH 09/13] Modify pull request permissions in slash_clippy.yml Updated permissions for pull requests and adjusted job-specific permissions. --- .github/workflows/slash_clippy.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index e74f20f8..1bb52368 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -3,25 +3,21 @@ name: SlashClippy on: issue_comment: types: [created] + permissions: contents: write issues: write - pull-requests: write + pull-requests: read jobs: dispatch: if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '/clippy') }} runs-on: ubuntu-latest - - # job-specific permissions - required for reactions permissions: - contents: write issues: write pull-requests: write - steps: - - name: Dispatch Clippy Command - uses: peter-evans/slash-command-dispatch@v4 + - uses: peter-evans/slash-command-dispatch@v4 with: token: ${{ secrets.SLASH_COMMAND_PAT }} reaction-token: ${{ secrets.SLASH_COMMAND_PAT }} @@ -29,5 +25,3 @@ jobs: dispatch-type: repository issue-type: pull-request repository: ${{ github.repository }} - # test without condition - reactions: eyes From 2377a84dd28a8a69a03cebd52cf1d0086bf8b0d7 Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:26:26 -0500 Subject: [PATCH 10/13] Update tokens in slash_clippy.yml to use GITHUB_TOKEN --- .github/workflows/slash_clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index 1bb52368..3137e3b0 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -19,8 +19,8 @@ jobs: steps: - uses: peter-evans/slash-command-dispatch@v4 with: - token: ${{ secrets.SLASH_COMMAND_PAT }} - reaction-token: ${{ secrets.SLASH_COMMAND_PAT }} + token: ${{ secrets.GITHUB_TOKEN }} + reaction-token: ${{ secrets.GITHUB_TOKEN }} commands: clippy dispatch-type: repository issue-type: pull-request From ea6dac1c39e631d95107a570a45cc708dc89337b Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:28:39 -0500 Subject: [PATCH 11/13] Update GitHub Actions to use SLASH_COMMAND_PAT --- .github/workflows/slash_clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/slash_clippy.yml b/.github/workflows/slash_clippy.yml index 3137e3b0..1bb52368 100644 --- a/.github/workflows/slash_clippy.yml +++ b/.github/workflows/slash_clippy.yml @@ -19,8 +19,8 @@ jobs: steps: - uses: peter-evans/slash-command-dispatch@v4 with: - token: ${{ secrets.GITHUB_TOKEN }} - reaction-token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ secrets.SLASH_COMMAND_PAT }} + reaction-token: ${{ secrets.SLASH_COMMAND_PAT }} commands: clippy dispatch-type: repository issue-type: pull-request From 25a9b44818ad2dc2809d02c9a6313b0a5d520f1e Mon Sep 17 00:00:00 2001 From: Dylan Kritter <100829534+dlkritter@users.noreply.github.com> Date: Sun, 2 Nov 2025 20:34:51 -0500 Subject: [PATCH 12/13] Update token retrieval in clippy.yml workflow --- .github/workflows/clippy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index 7196d1aa..b1756a9c 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -22,8 +22,8 @@ jobs: - name: Set token id: token run: | - if [ -n "${{ secrets.SLASH_COMMAND_PAT }}" ]; then - echo "token=${{ secrets.SLASH_COMMAND_PAT }}" >> "$GITHUB_OUTPUT" + if [ -n "${{ secrets.REPO_SCOPED_TOKEN }}" ]; then + echo "token=${{ secrets.REPO_SCOPED_TOKEN }}" >> "$GITHUB_OUTPUT" else echo "token=${{ secrets.GITHUB_TOKEN }}" >> "$GITHUB_OUTPUT" fi From c8b372b372958065da00ddc3562446ed6ba63a76 Mon Sep 17 00:00:00 2001 From: dylan-kritter Date: Sun, 2 Nov 2025 20:43:11 -0500 Subject: [PATCH 13/13] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index b7c3b96b..a4b56207 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,8 @@ Welcome to Aria. Aria is a modern, dynamic scripting language. It is meant to be a "sweet spot" language, easy to pick-up and with a good balance between ease of use, safety, and flexibility. Aria's design choices help you build great programs quickly. +bang + Aria has modern, safer error handling: Aria replaces unreliable `None` pointer checks with a modern, multi-tiered approach to error handling. By emphasizing algebraic data types (e.g. `Maybe`), Aria makes errors explicit, safer, and easier to manage, with fewer runtime surprises. `null`, the [billion dollar mistake](https://softwareengineering.stackexchange.com/questions/413149/if-null-is-a-billion-dollar-mistake-what-is-the-solution-to-represent-a-non-ini) just does not exist in Aria, making code safer, easier to maintain and error handling more robust.