From 4a10c322185cd604997ca4cbf563064a99f351fb Mon Sep 17 00:00:00 2001
From: dradis-bot <286253174+dradis-bot@users.noreply.github.com>
Date: Thu, 16 Jul 2026 08:39:39 +0100
Subject: [PATCH 1/4] Echo: retire the legacy Roslin one-shot interaction path

Slice 5 repurposed InteractionsController#index/#preview into the sessions
landing, leaving #create/#show and InteractionJob as the last remnants of the
Roslin one-shot prototype. Remove them now that ReplyJob-backed sessions are
live, so the record panel keeps only the sessions entry point.
---
 .../echo/projects/interactions_controller.rb  | 21 +-----
 .../dradis/plugins/echo/interaction_job.rb    | 32 ---------
 engines/dradis-echo/config/routes.rb          |  2 +-
 .../plugins/echo/interaction_job_spec.rb      | 70 -------------------
 .../echo/projects/interactions_spec.rb        | 21 ++++++
 5 files changed, 24 insertions(+), 122 deletions(-)
 delete mode 100644 engines/dradis-echo/app/jobs/dradis/plugins/echo/interaction_job.rb
 delete mode 100644 engines/dradis-echo/spec/jobs/dradis/plugins/echo/interaction_job_spec.rb

diff --git a/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb b/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
index 317c74837..22448d791 100644
--- a/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
+++ b/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
@@ -5,8 +5,8 @@ class Projects::InteractionsController < AuthenticatedController
 
     before_action :check_turbo_config, only: [:index]
     before_action :set_type
-    before_action :set_prompt, only: [:preview, :show]
-    before_action :set_record, except: [:create]
+    before_action :set_prompt, only: [:preview]
+    before_action :set_record
 
     def index
       Prompt.seed_default_prompts(current_user) if current_user.prompts.empty?
@@ -17,23 +17,6 @@ def index
 
     def preview; end
 
-    def show
-      @prompt_content = params[:prompt]
-      @interaction_id = SecureRandom.hex(20)
-      @response_id = SecureRandom.hex(10)
-    end
-
-    def create
-      InteractionJob.perform_later(
-        agent_id: Agents::Roslin.id,
-        prompt: params[:prompt],
-        interaction_id: params[:interaction_id],
-        response_id: params[:response_id]
-      )
-
-      head :ok
-    end
-
     private
 
     def check_turbo_config
diff --git a/engines/dradis-echo/app/jobs/dradis/plugins/echo/interaction_job.rb b/engines/dradis-echo/app/jobs/dradis/plugins/echo/interaction_job.rb
deleted file mode 100644
index 0a358f50e..000000000
--- a/engines/dradis-echo/app/jobs/dradis/plugins/echo/interaction_job.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-module Dradis::Plugins::Echo
-  class InteractionJob < ApplicationJob
-    queue_as :dradis_project
-
-    def perform(agent_id:, prompt:, interaction_id:, response_id:)
-      agent = Agent.find(agent_id)
-      raise "Agent '#{agent.name}' is not enabled" unless agent.enabled?
-
-      spinner_shown = true
-
-      agent.provider.generate(prompt: prompt, model: agent.model_override) do |chunk|
-        if spinner_shown
-          Turbo::StreamsChannel.broadcast_remove_to [interaction_id, 'prompts'], target: "#{response_id}_spinner"
-          spinner_shown = false
-        end
-
-        Turbo::StreamsChannel.broadcast_append_to(
-          [interaction_id, 'prompts'],
-          target: response_id,
-          content: ERB::Util.html_escape(chunk)
-        )
-      end
-
-      Turbo::StreamsChannel.broadcast_append_to [interaction_id, 'prompts'], target: 'messages', html: '<p>Done.</p>'
-    rescue => e
-      msg = '<div class="alert alert-danger m-0">'
-      msg << ERB::Util.html_escape(e.message)
-      msg << '</div>'
-      Turbo::StreamsChannel.broadcast_update_to [interaction_id, 'prompts'], target: response_id, html: msg
-    end
-  end
-end
diff --git a/engines/dradis-echo/config/routes.rb b/engines/dradis-echo/config/routes.rb
index 652d88aeb..55c88d4b0 100644
--- a/engines/dradis-echo/config/routes.rb
+++ b/engines/dradis-echo/config/routes.rb
@@ -5,7 +5,7 @@
 
     resources :projects, only: [] do
       scope module: 'projects' do
-        resources :interactions, only: [:index, :show, :create] do
+        resources :interactions, only: [:index] do
           get :preview, on: :member
         end
 
diff --git a/engines/dradis-echo/spec/jobs/dradis/plugins/echo/interaction_job_spec.rb b/engines/dradis-echo/spec/jobs/dradis/plugins/echo/interaction_job_spec.rb
deleted file mode 100644
index b7e3cf0ad..000000000
--- a/engines/dradis-echo/spec/jobs/dradis/plugins/echo/interaction_job_spec.rb
+++ /dev/null
@@ -1,70 +0,0 @@
-require 'rails_helper'
-require File.expand_path('../../../../factories/agents', __dir__)
-require File.expand_path('../../../../factories/providers', __dir__)
-
-describe Dradis::Plugins::Echo::InteractionJob do
-  let(:interaction_id) { 'project-1' }
-  let(:response_id) { 'response-1' }
-  let(:prompt) { 'Summarise this issue.' }
-  let(:agent) { create(:system_agent) }
-
-  def perform
-    described_class.perform_now(
-      agent_id: agent.id,
-      prompt: prompt,
-      interaction_id: interaction_id,
-      response_id: response_id
-    )
-  end
-
-  before do
-    allow(Turbo::StreamsChannel).to receive(:broadcast_append_to)
-    allow(Turbo::StreamsChannel).to receive(:broadcast_remove_to)
-    allow(Turbo::StreamsChannel).to receive(:broadcast_update_to)
-  end
-
-  describe 'when agent is not enabled' do
-    before { agent.update!(enabled: false) }
-
-    it 'broadcasts a user-friendly error' do
-      perform
-      expect(Turbo::StreamsChannel).to have_received(:broadcast_update_to) do |_, **kwargs|
-        expect(kwargs[:html]).to include('is not enabled')
-      end
-    end
-  end
-
-  describe 'error message sanitisation' do
-    it 'HTML-escapes the error message before broadcasting' do
-      allow_any_instance_of(Dradis::Plugins::Echo::Provider::Ollama)
-        .to receive(:generate).and_raise('<script>alert(1)</script>')
-
-      perform
-      expect(Turbo::StreamsChannel).to have_received(:broadcast_update_to) do |_, **kwargs|
-        expect(kwargs[:html]).to include('&lt;script&gt;')
-        expect(kwargs[:html]).not_to include('<script>')
-      end
-    end
-  end
-
-  describe 'successful streaming' do
-    before do
-      allow_any_instance_of(Dradis::Plugins::Echo::Provider::Ollama)
-        .to receive(:generate).and_yield('Hello ').and_yield('world')
-    end
-
-    it 'removes the spinner on the first chunk' do
-      perform
-      expect(Turbo::StreamsChannel).to have_received(:broadcast_remove_to)
-        .with([interaction_id, 'prompts'], target: "#{response_id}_spinner")
-    end
-
-    it 'broadcasts each chunk to the response target' do
-      perform
-      expect(Turbo::StreamsChannel).to have_received(:broadcast_append_to)
-        .with([interaction_id, 'prompts'], target: response_id, content: 'Hello ')
-      expect(Turbo::StreamsChannel).to have_received(:broadcast_append_to)
-        .with([interaction_id, 'prompts'], target: response_id, content: 'world')
-    end
-  end
-end
diff --git a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
index d81ec3024..85edab513 100644
--- a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
+++ b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
@@ -25,6 +25,13 @@
   end
 
   describe 'GET /addons/echo/projects/:project_id/interactions' do
+    it 'renders the sessions panel entry point' do
+      get "/addons/echo/projects/#{@project.id}/interactions", params: { type: 'issue', record: issue.id }
+
+      expect(response).to have_http_status(:ok)
+      expect(response.body).to include('Start a new conversation')
+    end
+
     it 'wraps the conversation list in the record Echo turbo-frame' do
       get "/addons/echo/projects/#{@project.id}/interactions",
         params: { type: 'issue', record: issue.id }
@@ -49,4 +56,18 @@
       expect(response.body).to include(ERB::Util.html_escape(new_conversation_link))
     end
   end
+
+  describe 'the retired Roslin one-shot path' do
+    it 'no longer exposes a create route' do
+      expect {
+        post "/addons/echo/projects/#{@project.id}/interactions", params: { type: 'issue', record: issue.id }
+      }.to raise_error(ActionController::RoutingError)
+    end
+
+    it 'no longer exposes a show route' do
+      expect {
+        get "/addons/echo/projects/#{@project.id}/interactions/1", params: { type: 'issue', record: issue.id }
+      }.to raise_error(ActionController::RoutingError)
+    end
+  end
 end

From d03a40f26e5ce9e45cb047fbf3b4b60c990e741f Mon Sep 17 00:00:00 2001
From: dradis-bot <286253174+dradis-bot@users.noreply.github.com>
Date: Thu, 16 Jul 2026 08:39:46 +0100
Subject: [PATCH 2/4] Echo: make provider #generate accept messages: only

The prompt: sugar and resolve_messages existed solely for the one-shot
InteractionJob path, which is now gone. ReplyJob already calls
generate(messages:), so drop the single-string convenience and require a
multi-turn messages array everywhere.
---
 .../plugins/echo/provider/http_streaming.rb    | 12 +++++-------
 .../app/models/dradis/plugins/echo/provider.rb | 17 +----------------
 .../dradis/plugins/echo/provider/ollama.rb     |  5 ++---
 .../echo/provider/http_streaming_spec.rb       | 16 +++-------------
 .../plugins/echo/provider/ollama_spec.rb       | 18 +++++-------------
 .../dradis/plugins/echo/provider_spec.rb       |  2 +-
 6 files changed, 17 insertions(+), 53 deletions(-)

diff --git a/engines/dradis-echo/app/models/concerns/dradis/plugins/echo/provider/http_streaming.rb b/engines/dradis-echo/app/models/concerns/dradis/plugins/echo/provider/http_streaming.rb
index 9f13233a2..0f98005a0 100644
--- a/engines/dradis-echo/app/models/concerns/dradis/plugins/echo/provider/http_streaming.rb
+++ b/engines/dradis-echo/app/models/concerns/dradis/plugins/echo/provider/http_streaming.rb
@@ -23,25 +23,23 @@ class Error < StandardError; end
       OpenSSL::SSL::SSLError
     ].freeze
 
-    # Sends prompt to the provider and returns the response.
+    # Sends the conversation to the provider and returns the response.
     #
     # With a block: yields each text chunk as it arrives, enabling streaming UX
-    # (e.g. InteractionJob broadcasts each chunk to the browser via Turbo).
+    # (e.g. ReplyJob broadcasts each chunk to the browser via Turbo).
     #
     # Without a block: accumulates all chunks and returns the complete response
     # as a string once the API finishes, for use outside a streaming context.
     #
-    # Accepts a multi-turn messages: array ([{ role:, content: }]) or the
-    # prompt: sugar for a single user message.
+    # Accepts a multi-turn messages: array ([{ role:, content: }]).
     #
     # Subclasses must implement: #build_uri, #build_headers, #build_body,
     # #extract_text. Optionally override #end_of_stream_marker.
-    def generate(messages: nil, prompt: nil, model: nil, &block)
+    def generate(messages:, model: nil, &block)
       resolved_model = model.presence || self.model
-      resolved_messages = resolve_messages(messages, prompt)
       uri = build_uri(resolved_model)
       headers = build_headers
-      body = build_body(messages: resolved_messages, model: resolved_model)
+      body = build_body(messages: messages, model: resolved_model)
 
       buffer = block ? nil : +''
 
diff --git a/engines/dradis-echo/app/models/dradis/plugins/echo/provider.rb b/engines/dradis-echo/app/models/dradis/plugins/echo/provider.rb
index bf181d5b9..2942b3859 100644
--- a/engines/dradis-echo/app/models/dradis/plugins/echo/provider.rb
+++ b/engines/dradis-echo/app/models/dradis/plugins/echo/provider.rb
@@ -40,7 +40,7 @@ def self.inherited(subclass)
 
     # -- Instance Methods -----------------------------------------------------
 
-    def generate(messages: nil, prompt: nil, model: nil, &block)
+    def generate(messages:, model: nil, &block)
       raise NotImplementedError, "#{self.class.name} must implement #generate"
     end
 
@@ -55,20 +55,5 @@ def requires_api_key?
     def type_name
       self.class.name.demodulize
     end
-
-    private
-
-    # Normalizes the two ways to call #generate into a messages array. Callers
-    # pass either a multi-turn messages: array or the prompt: sugar, which wraps
-    # a single string into one user message.
-    def resolve_messages(messages, prompt)
-      if messages
-        messages
-      elsif prompt
-        [{ role: 'user', content: prompt }]
-      else
-        raise ArgumentError, '#generate requires either messages: or prompt:'
-      end
-    end
   end
 end
diff --git a/engines/dradis-echo/app/models/dradis/plugins/echo/provider/ollama.rb b/engines/dradis-echo/app/models/dradis/plugins/echo/provider/ollama.rb
index d2333ffb1..2d174225c 100644
--- a/engines/dradis-echo/app/models/dradis/plugins/echo/provider/ollama.rb
+++ b/engines/dradis-echo/app/models/dradis/plugins/echo/provider/ollama.rb
@@ -7,12 +7,11 @@ def requires_api_key?
       false
     end
 
-    def generate(messages: nil, prompt: nil, model: nil, &block)
+    def generate(messages:, model: nil, &block)
       resolved_model = model.presence || self.model
-      resolved_messages = resolve_messages(messages, prompt)
       buffer = block_given? ? nil : +''
 
-      client.chat({ model: resolved_model, messages: resolved_messages }) do |event, _raw|
+      client.chat({ model: resolved_model, messages: messages }) do |event, _raw|
         next if event['done']
 
         chunk = event.dig('message', 'content').to_s
diff --git a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/http_streaming_spec.rb b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/http_streaming_spec.rb
index 4b43c28a7..a14af2e5c 100644
--- a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/http_streaming_spec.rb
+++ b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/http_streaming_spec.rb
@@ -81,7 +81,7 @@ def stub_http(body:, code: '200')
       sse_body = "data: #{JSON.generate(delta_event)}\n\n"
       stub_http(body: sse_body)
 
-      result = provider.generate(prompt: 'test')
+      result = provider.generate(messages: [{ role: 'user', content: 'test' }])
       expect(result).to eq('Hello')
     end
 
@@ -91,7 +91,7 @@ def stub_http(body:, code: '200')
       stub_http(body: sse_body)
 
       chunks = []
-      result = provider.generate(prompt: 'test') { |chunk| chunks << chunk }
+      result = provider.generate(messages: [{ role: 'user', content: 'test' }]) { |chunk| chunks << chunk }
       expect(chunks).to eq(['Hello'])
       expect(result).to be_nil
     end
@@ -112,17 +112,7 @@ def stub_http(body:, code: '200')
       expect(provider.generate(messages: messages)).to eq('Hello')
     end
 
-    it 'wraps the prompt: sugar into a single user message' do
-      stub_http(body: '')
-
-      expect(provider).to receive(:build_body)
-        .with(messages: [{ role: 'user', content: 'test' }], model: 'claude-sonnet-4-6')
-        .and_call_original
-
-      provider.generate(prompt: 'test')
-    end
-
-    it 'raises when neither messages: nor prompt: is given' do
+    it 'raises when messages: is not given' do
       expect { provider.generate }.to raise_error(ArgumentError)
     end
   end
diff --git a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/ollama_spec.rb b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/ollama_spec.rb
index 843d326eb..e1c7911ad 100644
--- a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/ollama_spec.rb
+++ b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider/ollama_spec.rb
@@ -29,7 +29,7 @@ def content_event(content, done: false)
         content_event('', done: true)
       )
 
-      expect(provider.generate(prompt: 'hi')).to eq('Hello world')
+      expect(provider.generate(messages: [{ role: 'user', content: 'hi' }])).to eq('Hello world')
     end
 
     it 'preserves whitespace-only chunks, such as standalone line breaks' do
@@ -40,7 +40,7 @@ def content_event(content, done: false)
         content_event('', done: true)
       )
 
-      expect(provider.generate(prompt: 'hi')).to eq("1. First item.  \n2. Second item.")
+      expect(provider.generate(messages: [{ role: 'user', content: 'hi' }])).to eq("1. First item.  \n2. Second item.")
     end
 
     it 'skips events with empty content, such as thinking-only chunks' do
@@ -50,7 +50,7 @@ def content_event(content, done: false)
         content_event('', done: true)
       )
 
-      expect(provider.generate(prompt: 'hi')).to eq('Answer')
+      expect(provider.generate(messages: [{ role: 'user', content: 'hi' }])).to eq('Answer')
     end
 
     it 'replaces think tags embedded in the response text' do
@@ -62,7 +62,7 @@ def content_event(content, done: false)
         content_event('', done: true)
       )
 
-      expect(provider.generate(prompt: 'hi')).to eq('{thinking}reasoning{/thinking}Answer')
+      expect(provider.generate(messages: [{ role: 'user', content: 'hi' }])).to eq('{thinking}reasoning{/thinking}Answer')
     end
 
     it 'yields each chunk to the given block instead of buffering' do
@@ -73,7 +73,7 @@ def content_event(content, done: false)
       )
 
       chunks = []
-      provider.generate(prompt: 'hi') { |chunk| chunks << chunk }
+      provider.generate(messages: [{ role: 'user', content: 'hi' }]) { |chunk| chunks << chunk }
 
       expect(chunks).to eq(['Hello ', 'world'])
     end
@@ -90,13 +90,5 @@ def content_event(content, done: false)
 
       expect(provider.generate(messages: messages)).to eq('ok')
     end
-
-    it 'wraps the prompt: sugar into a single user message' do
-      expect(client).to receive(:chat)
-        .with(hash_including(messages: [{ role: 'user', content: 'hi' }]))
-        .and_yield(content_event('ok'), nil)
-
-      provider.generate(prompt: 'hi')
-    end
   end
 end
diff --git a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider_spec.rb b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider_spec.rb
index 4ad8257b7..f25f5b6dd 100644
--- a/engines/dradis-echo/spec/models/dradis/plugins/echo/provider_spec.rb
+++ b/engines/dradis-echo/spec/models/dradis/plugins/echo/provider_spec.rb
@@ -94,7 +94,7 @@
       provider = build(:provider)
       # Ollama overrides #generate, so test the base class directly
       expect do
-        Dradis::Plugins::Echo::Provider.new.generate(prompt: 'test')
+        Dradis::Plugins::Echo::Provider.new.generate(messages: [{ role: 'user', content: 'test' }])
       end.to raise_error(NotImplementedError)
     end
   end

From 2ccb0123ea3a8bf18bb3297173b2d354cad9d336 Mon Sep 17 00:00:00 2001
From: Product - Coder <etd-claude@nomejortu.com>
Date: Fri, 17 Jul 2026 11:49:32 +0100
Subject: [PATCH 3/4] Echo: dedupe cable check and harden interactions dispatch

Applies PR #1655 review findings on the retire slice:

- check_turbo_config (#10): interactions_controller now uses the shared
  TurboConfigCheck concern instead of its own Redis-pinging copy, so
  non-Redis adapters no-op silently.
- Blank type (nit): set_record raises RecordNotFound when @type is blank
  so an unknown/missing type returns 404 instead of a 500 from
  send('').pluralize, mirroring SessionsController#set_record.
- set_prompt (nit): scope the preview prompt lookup through .for(@type)
  like sessions#create, honouring the Prompt::SCOPES whitelist.

The conversations N+1 fix (includes(:user) + grouped counts) is carried
up from the views slice and remains applied to interactions#index here.
---
 .../echo/projects/interactions_controller.rb       | 14 ++++----------
 .../plugins/echo/projects/interactions_spec.rb     |  6 ++++++
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb b/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
index 22448d791..9078e04c1 100644
--- a/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
+++ b/engines/dradis-echo/app/controllers/dradis/plugins/echo/projects/interactions_controller.rb
@@ -1,6 +1,7 @@
 module Dradis::Plugins::Echo
   class Projects::InteractionsController < AuthenticatedController
     include ProjectScoped
+    include TurboConfigCheck
     layout false
 
     before_action :check_turbo_config, only: [:index]
@@ -19,15 +20,6 @@ def preview; end
 
     private
 
-    def check_turbo_config
-      @turbo_status = begin
-        ActionCable.server.pubsub.redis_connection_for_subscriptions.ping
-        true
-      rescue
-        false
-      end
-    end
-
     def liquid_parse(template)
       assigns = { 'issue' => IssueDrop.new(@record) }
 
@@ -46,10 +38,12 @@ def record_params
     end
 
     def set_prompt
-      @prompt = current_user.prompts.find(params[:id])
+      @prompt = current_user.prompts.for(@type).find(params[:id])
     end
 
     def set_record
+      raise ActiveRecord::RecordNotFound if @type.blank?
+
       @record = current_project.send(@type.to_s.pluralize).find(record_params[:record])
     end
 
diff --git a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
index 85edab513..bb8f23366 100644
--- a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
+++ b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
@@ -55,6 +55,12 @@
       # href attributes HTML-escape the query separator (& -> &amp;); match escaped.
       expect(response.body).to include(ERB::Util.html_escape(new_conversation_link))
     end
+
+    it 'raises RecordNotFound (404) rather than a 500 for a missing or unknown type' do
+      expect {
+        get "/addons/echo/projects/#{@project.id}/interactions", params: { record: issue.id }
+      }.to raise_error(ActiveRecord::RecordNotFound)
+    end
   end
 
   describe 'the retired Roslin one-shot path' do

From 265142e068a39a01bba08a8b6cdd1c2cec91503a Mon Sep 17 00:00:00 2001
From: Product - Coder <etd-claude@nomejortu.com>
Date: Wed, 22 Jul 2026 15:49:08 +0100
Subject: [PATCH 4/4] Echo: use do...end for multi-line expect blocks in specs

Pre-existing Style/BlockDelimiters offenses across Echo spec files that
would break CI once this stack merges onto develop (where the cop is
enabled). Spec-only, parse-equivalent delimiter change.
---
 .../plugins/echo/projects/interactions_spec.rb       | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
index bb8f23366..5aa422320 100644
--- a/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
+++ b/engines/dradis-echo/spec/requests/dradis/plugins/echo/projects/interactions_spec.rb
@@ -57,23 +57,23 @@
     end
 
     it 'raises RecordNotFound (404) rather than a 500 for a missing or unknown type' do
-      expect {
+      expect do
         get "/addons/echo/projects/#{@project.id}/interactions", params: { record: issue.id }
-      }.to raise_error(ActiveRecord::RecordNotFound)
+      end.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
   describe 'the retired Roslin one-shot path' do
     it 'no longer exposes a create route' do
-      expect {
+      expect do
         post "/addons/echo/projects/#{@project.id}/interactions", params: { type: 'issue', record: issue.id }
-      }.to raise_error(ActionController::RoutingError)
+      end.to raise_error(ActionController::RoutingError)
     end
 
     it 'no longer exposes a show route' do
-      expect {
+      expect do
         get "/addons/echo/projects/#{@project.id}/interactions/1", params: { type: 'issue', record: issue.id }
-      }.to raise_error(ActionController::RoutingError)
+      end.to raise_error(ActionController::RoutingError)
     end
   end
 end