Export of guava shaded packages for OSGI #1727
michalkelnar
started this conversation in
General
Replies: 1 comment 1 reply
|
Can you add these exports (should be similar to #1709 ?) and see if it works? I don't have an OSGi environment, so I rely on feedback from you guys for these changes. |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I am using milo 1.0.8 in osgi environment repackaged so it exports shaded guava packages and when I saw that 1.1.2 now exports them I have tried it directly, but it looks like not all are exported.
It exports just org.eclipse.milo.shaded.com.google.common and org.eclipse.milo.shaded.com.google.common.collect, but as milo-stack-core imports com.google.common.primitives it should export it as well as org.eclipse.milo.shaded.com.google.common.primitives.
For my use case it was enough to export in my repackaged bundle.
org.eclipse.milo.shaded.com.google.common,
org.eclipse.milo.shaded.com.google.common.primitives,
org.eclipse.milo.shaded.com.google.common.collect
but I am not using full potential of milo.
I have went through milo-stack-core and milo-sdk-client and they are use these:
com.google.common.collect
com.google.common.primitives
com.google.common.base
com.google.common.cache
So maybe all of these should be exported.
It looks like org.eclipse.milo.shaded.com.google.common.* in poms
org.eclipse.milo.shaded.com.google.common.*,
org.eclipse.milo.shaded.com.google.common.collect,
*
does not export all packages.
All reactions