Skip to content

v3.5#1730

Merged
elalish merged 1 commit into
masterfrom
v3.5
May 23, 2026
Merged

v3.5#1730
elalish merged 1 commit into
masterfrom
v3.5

Conversation

@elalish

@elalish elalish commented May 23, 2026

Copy link
Copy Markdown
Owner

A huge thank you to all our new contributors - so much has happened in this release! And a special shoutout to @zmerlynn for a huge amount of work, including a whole new progress and cancellation API. @AnshulPatil2005 has now pushed Manifold to be double-precision deterministic across architectures. There's also been lot of UX improvement in ManifoldCAD, largely thanks to @swaparup36.

New Features

Performance Improvements

Bug Fixes

Bindings

ManifoldCAD

Tests and CI

Build

Miscellaneous

New Contributors

Full Changelog: v3.4.1...v3.5.0

@elalish elalish self-assigned this May 23, 2026
@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.10%. Comparing base (9719c34) to head (7e57ec7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1730   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          37       37           
  Lines        8296     8296           
=======================================
  Hits         7890     7890           
  Misses        406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elalish elalish merged commit 541c33b into master May 23, 2026
40 checks passed
@elalish elalish deleted the v3.5 branch May 23, 2026 04:25
@elalish

elalish commented May 23, 2026

Copy link
Copy Markdown
Owner Author

@pca006132 Argh, will we ever get a release to publish all the packages correctly the first time? Somehow npm is trying to publish as 3.4.1 again even though I searched and that string doesn't exist in our repo anymore. Do you have any idea how it could be getting the wrong one?

@zmerlynn

Copy link
Copy Markdown
Contributor

Claude theory: the repo itself is fine - bindings/wasm/package.json is 3.5.0 in master. But publish_npm.yml downloads the latest completed wasm artifact into ./bindings/wasm/, and that artifact is the entire dir - so its package.json overwrites the checked-out 3.5.0 one. If the release was triggered before the post-#1730 master build finished, the artifact still had 3.4.1, and that's what npm publish saw.

Fix would be narrowing the wasm artifact to just build outputs (not the whole bindings/wasm/ tree), or having publish_npm not clobber package.json from it.

@elalish

elalish commented May 23, 2026

Copy link
Copy Markdown
Owner Author

Sure enough, on a rerun it worked, so sounds like Claude knows. Narrowing the wasm artifact sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failure

2 participants