[mob][locker] Collection link sharing for locker#9952
[mob][locker] Collection link sharing for locker#9952AmanRajSinghMourya wants to merge 7 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20af00bb47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!_hasActivePublicLink) { | ||
| await _createAndSharePublicLink(); | ||
| return; |
There was a problem hiding this comment.
The link action currently treats expired links the same as having no link, so owners with an expired public URL go through _createAndSharePublicLink() instead of opening ManageSharedLinkWidget. In that flow, createShareUrl() appends a URL to collection.publicURLs (in collections_api_client.dart), while this sheet still reads publicURLs.first, which remains the expired entry; _hasActivePublicLink stays false, so the UI can keep offering “Link” and skip sharing/managing the newly created URL. This blocks normal recovery for expired-link collections and can cause repeated create attempts.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56ddaa5042
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Description
Adds public-link support for Locker collections on mobile, including link creation, sharing, and link management.
- link expiry
- device limit
- password lock