From 8283ebd91d162aa8c5c277d4edd7318ff142bb9c Mon Sep 17 00:00:00 2001
From: Sam Agarwal <samagarwal082@gmail.com>
Date: Sun, 12 Jul 2026 19:40:48 -0400
Subject: [PATCH] test: cover toolRegistry selection and metadata helpers

toolRegistry.ts had no test coverage despite holding the pure logic that drives
tool selection. Add tests/unit/toolRegistry.test.ts for:

- isToolEnabledByDefault / requiresUserProvidedApiKey / isAgentTool reading the
  registry flags (incl. isAgentTool agreeing with AGENT_TOOL_IDS registry-wide);
- expandToolSelection: agent_tools alias expansion, dedup with first-seen order,
  dedup across an alias and an explicit member, and silent-skip of unknown ids;
- listToolMetadata: only registered tools marked enabled, full-registry coverage,
  and name/description surfaced for every entry.

Tests only; no source changes.
---
 tests/unit/toolRegistry.test.ts | 90 +++++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)
 create mode 100644 tests/unit/toolRegistry.test.ts

diff --git a/tests/unit/toolRegistry.test.ts b/tests/unit/toolRegistry.test.ts
new file mode 100644
index 00000000..8847ea4a
--- /dev/null
+++ b/tests/unit/toolRegistry.test.ts
@@ -0,0 +1,90 @@
+import { describe, expect, it } from "vitest";
+import {
+  AGENT_TOOL_IDS,
+  AVAILABLE_TOOL_IDS,
+  expandToolSelection,
+  isAgentTool,
+  isToolEnabledByDefault,
+  listToolMetadata,
+  requiresUserProvidedApiKey,
+} from "../../src/toolRegistry.js";
+
+describe("isToolEnabledByDefault", () => {
+  it("reflects each tool's enabled flag", () => {
+    expect(isToolEnabledByDefault("web_search_exa")).toBe(true);
+    expect(isToolEnabledByDefault("web_fetch_exa")).toBe(true);
+    expect(isToolEnabledByDefault("web_search_advanced_exa")).toBe(false);
+    expect(isToolEnabledByDefault("agent_create_run")).toBe(false);
+  });
+});
+
+describe("requiresUserProvidedApiKey", () => {
+  it("is true only for tools that declare the flag", () => {
+    expect(requiresUserProvidedApiKey("deep_researcher_start")).toBe(true);
+    expect(requiresUserProvidedApiKey("agent_create_run")).toBe(true);
+  });
+
+  it("is false when the flag is absent", () => {
+    expect(requiresUserProvidedApiKey("web_search_exa")).toBe(false);
+    expect(requiresUserProvidedApiKey("web_fetch_exa")).toBe(false);
+  });
+});
+
+describe("isAgentTool", () => {
+  it("is true for the agent group and false otherwise", () => {
+    expect(isAgentTool("agent_create_run")).toBe(true);
+    expect(isAgentTool("agent_cancel_run")).toBe(true);
+    expect(isAgentTool("web_search_exa")).toBe(false);
+  });
+
+  it("agrees with AGENT_TOOL_IDS across the whole registry", () => {
+    for (const toolId of AVAILABLE_TOOL_IDS) {
+      expect(isAgentTool(toolId)).toBe(AGENT_TOOL_IDS.includes(toolId));
+    }
+  });
+});
+
+describe("expandToolSelection", () => {
+  it("expands the agent_tools alias to every agent tool id", () => {
+    expect(expandToolSelection(["agent_tools"])).toEqual(AGENT_TOOL_IDS);
+  });
+
+  it("deduplicates repeated ids and preserves first-seen order", () => {
+    expect(
+      expandToolSelection(["web_fetch_exa", "web_search_exa", "web_fetch_exa"]),
+    ).toEqual(["web_fetch_exa", "web_search_exa"]);
+  });
+
+  it("deduplicates across an alias and an explicit member of it", () => {
+    // agent_create_run is already included via the alias, so it is not repeated.
+    expect(expandToolSelection(["agent_tools", "agent_create_run"])).toEqual(
+      AGENT_TOOL_IDS,
+    );
+  });
+
+  it("silently skips ids that are not in the registry", () => {
+    expect(
+      expandToolSelection(["not_a_real_tool", "web_search_exa"]),
+    ).toEqual(["web_search_exa"]);
+    expect(expandToolSelection(["definitely_unknown"])).toEqual([]);
+  });
+});
+
+describe("listToolMetadata", () => {
+  it("marks only the registered tools as enabled and covers the whole registry", () => {
+    const metadata = listToolMetadata(["web_search_exa"]);
+
+    expect(metadata).toHaveLength(AVAILABLE_TOOL_IDS.length);
+
+    const bySelected = metadata.find((m) => m.id === "web_search_exa");
+    const byOther = metadata.find((m) => m.id === "web_fetch_exa");
+    expect(bySelected?.enabled).toBe(true);
+    expect(byOther?.enabled).toBe(false);
+
+    // Name/description are surfaced from the registry for every entry.
+    for (const entry of metadata) {
+      expect(entry.name).toBeTruthy();
+      expect(entry.description).toBeTruthy();
+    }
+  });
+});