From 16bb1fbcdb51e9c873ce498d715b72df4b76c64b Mon Sep 17 00:00:00 2001 From: j1nts01 Date: Wed, 5 Aug 2026 17:47:28 -0500 Subject: [PATCH 1/4] FDG-9226 making datatestid changes for ga events --- .../table-section-container/pivot-options/pivot-options.jsx | 3 ++- src/components/select-control/select-control.jsx | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/components/dataset-data/table-section-container/pivot-options/pivot-options.jsx b/src/components/dataset-data/table-section-container/pivot-options/pivot-options.jsx index c9fb21cdd2..953457890a 100644 --- a/src/components/dataset-data/table-section-container/pivot-options/pivot-options.jsx +++ b/src/components/dataset-data/table-section-container/pivot-options/pivot-options.jsx @@ -82,7 +82,7 @@ const PivotOptions = ({ datasetName, table, pivotSelection, setSelectedPivot, pi { return `Change ${ariaLabelText} from ${selectedOptionLabel}`; }; -const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandler, showAll, optionLabelKey, className }) => { +const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandler, showAll, optionLabelKey, className, dataTestId }) => { const labelKey = optionLabelKey ? optionLabelKey : 'label'; const [droppedDown, setDroppedDown] = useState(false); @@ -54,7 +54,7 @@ const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandle
diff --git a/src/components/dataset-data/table-section-container/pivot-toggle/pivot-toggle.spec.js b/src/components/dataset-data/table-section-container/pivot-toggle/pivot-toggle.spec.js index 25ec62c120..f71ab2da8a 100644 --- a/src/components/dataset-data/table-section-container/pivot-toggle/pivot-toggle.spec.js +++ b/src/components/dataset-data/table-section-container/pivot-toggle/pivot-toggle.spec.js @@ -22,7 +22,7 @@ describe('PivotToggle component', () => { it('fires its click handler when clicked', () => { const { getByTestId } = render(); expect(handlerTracker).toBeNull(); - fireEvent.click(getByTestId('pivotToggle')); + fireEvent.click(getByTestId('show-pivot-options')); expect(handlerTracker).toEqual('called'); }); }); diff --git a/src/components/select-control/select-control.jsx b/src/components/select-control/select-control.jsx index 9b7d1c4843..b75b53ae97 100644 --- a/src/components/select-control/select-control.jsx +++ b/src/components/select-control/select-control.jsx @@ -20,7 +20,7 @@ export const ariaLabeler = (selectedOptionLabel, ariaLabel, label) => { return `Change ${ariaLabelText} from ${selectedOptionLabel}`; }; -const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandler, showAll, optionLabelKey, className, dataTestId }) => { +const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandler, showAll, optionLabelKey, className, ga4Selector }) => { const labelKey = optionLabelKey ? optionLabelKey : 'label'; const [droppedDown, setDroppedDown] = useState(false); @@ -73,7 +73,7 @@ const SelectControl = ({ label, options, selectedOption, ariaLabel, changeHandle return ( {(!option.hideable || showAll) && ( -
  • +