Skip to content

TST mock download_subject test to improve flakyness #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdoc merged 3 commits into from
May 12, 2026
Merged

TST mock download_subject test to improve flakyness #640

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d463113
TST increase timeout for download_subject test
mvdoc May 11, 2026
691ee12
Reduce timeout to 5 min
mvdoc May 11, 2026
53fdc3c
TST mock download_subject to avoid network in tests
mvdoc May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cortex/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import cortex
import pytest

@pytest.mark.timeout(600)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

A timeout of 600 seconds (10 minutes) is exceptionally long for a single test and can significantly delay CI feedback loops. This duration is largely driven by the fact that the test downloads the 'fsaverage' subject twice (once on line 13 and again on line 16 with download_again=True).

To improve efficiency and reduce the risk of hitting timeouts, consider refactoring the test to:

  1. Download the subject only once.
  2. Use a smaller mock subject if the goal is specifically to test the download mechanism.
  3. Mark the test with @pytest.mark.slow or a custom network marker so it can be optionally skipped during rapid local development.

def test_download_subject():
# Test that newly downloaded subjects are added to the current database.

Expand Down