Skip to content

ci: Auto-accept API verifier changes in PRs #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 5 commits into
base: main
Choose a base branch
from

ci: Remove continue-on-error from artifact download steps

ed7001e
Select commit
Loading
Failed to load commit list.
Open

ci: Auto-accept API verifier changes in PRs #5228

ci: Remove continue-on-error from artifact download steps
ed7001e
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed May 20, 2026 in 2m 47s

1 issue

find-bugs: Found 1 issue (1 medium)

Medium

`continue-on-error: true` makes a total test-run failure indistinguishable from a clean API check - `.github/workflows/verify-api.yml:70-72`

If dotnet test fails for any reason other than snapshot mismatches (e.g. build error in the test project, missing workload, dotnet crash), no *.received.txt files are produced. accept-api-changes then finds no artifacts, commits nothing, and exits green — silently hiding the fact that the API tests never ran.

⏱ 2m 38s · 36.5k in / 7.7k out · $0.26

Annotations

Check warning on line 72 in .github/workflows/verify-api.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: find-bugs

`continue-on-error: true` makes a total test-run failure indistinguishable from a clean API check 

If `dotnet test` fails for any reason other than snapshot mismatches (e.g. build error in the test project, missing workload, dotnet crash), no `*.received.txt` files are produced. `accept-api-changes` then finds no artifacts, commits nothing, and exits green — silently hiding the fact that the API tests never ran.
View more details on @sentry/warden