From 650d9901f6340d845e10886fc3709b97e8c526d8 Mon Sep 17 00:00:00 2001
From: James Crosswell <james.crosswell@gmail.com>
Date: Fri, 15 May 2026 15:47:53 +1200
Subject: [PATCH] build: download ACKNOWLEDGEMENTS.md for sentry-cli when
 packing

The Sentry NuGet package redistributes the sentry-cli executables, which
compile third-party Rust crates whose OSS licenses require attribution.
Add a download step for the platform-independent ACKNOWLEDGEMENTS.md
alongside the existing platform-specific binary downloads so it is
automatically included in the tools\ folder of the published package.

ContinueOnError="WarnAndContinue" is used as a temporary fallback while
getsentry/sentry-cli#2823 (adding the file to releases) is in progress.
Once that ships the error handling can be tightened and hash verification
added via update-cli.ps1.

Closes #4588

#skip-changelog

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/Sentry/Sentry.csproj | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/Sentry/Sentry.csproj b/src/Sentry/Sentry.csproj
index 5d2129d7d1..b9870fb182 100644
--- a/src/Sentry/Sentry.csproj
+++ b/src/Sentry/Sentry.csproj
@@ -116,7 +116,7 @@
       <SentryCLIDownload Condition="'$(CI_PUBLISHING_BUILD)' == 'true' Or ($([MSBuild]::IsOSPlatform('Windows')) And $(_OSArchitecture) != 'X86')" Include="sentry-cli-Windows-x86_64.exe" FileHash="572b4a6c04504302a46e2e1c196ec31cda266b574b1444605426aa8e41d46b8c" />
     </ItemGroup>
 
-    <!-- Download the files -->
+    <!-- Download the platform-specific CLI binaries. -->
     <DownloadFile SourceUrl="https://downloads.sentry-cdn.com/sentry-cli/$(SentryCLIVersion)/%(SentryCLIDownload.Identity)" DestinationFolder="$(SentryCLIDirectory)" Condition="!Exists('$(SentryCLIDirectory)%(Identity)')" Retries="3">
       <Output TaskParameter="DownloadedFile" ItemName="SentryCLIDownloadedFile" />
     </DownloadFile>
@@ -124,6 +124,20 @@
     <!-- Build will fail if any downloaded files don't match the expected hash. -->
     <VerifyFileHash File="$(SentryCLIDirectory)%(SentryCLIDownload.Identity)" Hash="%(FileHash)" />
 
+    <!--
+      Download the platform-independent ACKNOWLEDGEMENTS.md that lists third-party OSS
+      attributions compiled into the sentry-cli binary. Required for license compliance
+      when redistributing the CLI executables in the Sentry NuGet package.
+      ContinueOnError is temporary while getsentry/sentry-cli#2823 is in progress —
+      remove it once sentry-cli starts publishing this file in releases.
+    -->
+    <DownloadFile
+      SourceUrl="https://downloads.sentry-cdn.com/sentry-cli/$(SentryCLIVersion)/ACKNOWLEDGEMENTS.md"
+      DestinationFolder="$(SentryCLIDirectory)"
+      Condition="!Exists('$(SentryCLIDirectory)ACKNOWLEDGEMENTS.md')"
+      ContinueOnError="WarnAndContinue"
+      Retries="3" />
+
     <!-- Set executable permissions for local usage. -->
     <Exec Command="chmod +x $(SentryCLIDirectory)*" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
   </Target>