Skip to content

Add Escape key handling for inline search in SInputDropdown#669

Merged
brc-dd merged 3 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661-another-one
Dec 8, 2025
Merged

Add Escape key handling for inline search in SInputDropdown#669
brc-dd merged 3 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661-another-one

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 8, 2025

Adds standard Escape key behavior to the inline search dropdown: first press clears the search query, second press closes the dropdown.

Changes:

  • Added Escape key handler in handleInlineKeydown:
    • Clears inlineQuery and inlineActiveIndex when query exists
    • Closes dropdown via close() when query is empty
  • Added test coverage for all Escape key scenarios

Behavior:

// User types "Opt" in search
handleInlineKeydown({ key: 'Escape' })  // Clears query, dropdown stays open
handleInlineKeydown({ key: 'Escape' })  // Closes dropdown

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 8, 2025 02:47
- Pressing Escape with text clears the search query
- Pressing Escape with empty query closes the dropdown
- Added comprehensive tests for Escape key behavior

Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on inline search functionality for input dropdown Add Escape key handling for inline search in SInputDropdown Dec 8, 2025
Copilot AI requested a review from brc-dd December 8, 2025 02:51
@brc-dd brc-dd marked this pull request as ready for review December 8, 2025 02:55
@brc-dd brc-dd requested a review from kiaking as a code owner December 8, 2025 02:55
@brc-dd brc-dd merged commit 4d9ad33 into feat/inline-search-dropdown Dec 8, 2025
1 check passed
@brc-dd brc-dd deleted the copilot/sub-pr-661-another-one branch December 8, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants