diff --git a/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java index d414d00c36b3..bdd8c033f018 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java @@ -52,8 +52,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - CollectionTestSuiteBuilder.using( - new ReserializedCollectionGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedCollectionGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java index 51a7bc6cd1a2..36906dd603f3 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java @@ -109,8 +109,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - ListTestSuiteBuilder.using( - new ReserializedListGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedListGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java index 8a41545692fc..48a6b81fc3e9 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java @@ -97,8 +97,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MapTestSuiteBuilder.using( - new ReserializedMapGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeReserializedMapFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " reserialized") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java index ed65a07c487d..933f19f3427c 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java @@ -75,8 +75,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - SetTestSuiteBuilder.using( - new ReserializedSetGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedSetGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java index 28b5572e974f..5178a29c6f99 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java @@ -110,8 +110,7 @@ protected List createDerivedSuites( .createTestSuite()); if (!parentBuilder.getFeatures().contains(NoRecurse.INVERSE)) { derived.add( - BiMapTestSuiteBuilder.using( - new InverseBiMapGenerator(parentBuilder.getSubjectGenerator())) + using(new InverseBiMapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeInverseFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " inverse") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java index abca6481fd01..21a6b9ca2380 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java @@ -112,8 +112,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MultimapTestSuiteBuilder.using( - new ReserializedMultimapGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMultimapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeReserializedMultimapFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " reserialized") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java index 30711a57404e..a2dbbbe66cc7 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java @@ -138,8 +138,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MultisetTestSuiteBuilder.using( - new ReserializedMultisetGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMultisetGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedMultisetFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/android/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java b/android/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java index e806af0bd3ec..fc6f22b532b0 100644 --- a/android/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java +++ b/android/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java @@ -162,7 +162,7 @@ private TestSuite createSubMultisetSuite( E firstInclusive = samplesList.get(0); E lastInclusive = samplesList.get(samplesList.size() - 1); - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { @@ -244,7 +244,7 @@ private TestSuite createDescendingSuite(SortedMultisetTestSuiteBuilder parent features.remove(SERIALIZABLE); } - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { @@ -270,7 +270,7 @@ private TestSuite createReserializedSuite(SortedMultisetTestSuiteBuilder pare features.remove(SERIALIZABLE); features.remove(SERIALIZABLE_INCLUDING_VIEWS); - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { diff --git a/android/guava/src/com/google/common/base/Optional.java b/android/guava/src/com/google/common/base/Optional.java index d49d8723fa84..ac5575ba3328 100644 --- a/android/guava/src/com/google/common/base/Optional.java +++ b/android/guava/src/com/google/common/base/Optional.java @@ -117,7 +117,7 @@ public static Optional of(T reference) { * {@code Optional.ofNullable}. */ public static Optional fromNullable(@Nullable T nullableReference) { - return (nullableReference == null) ? Optional.absent() : new Present<>(nullableReference); + return nullableReference == null ? absent() : new Present<>(nullableReference); } /** diff --git a/android/guava/src/com/google/common/base/Splitter.java b/android/guava/src/com/google/common/base/Splitter.java index 624eea2c3094..9031dd53f5c5 100644 --- a/android/guava/src/com/google/common/base/Splitter.java +++ b/android/guava/src/com/google/common/base/Splitter.java @@ -165,7 +165,7 @@ int separatorEnd(int separatorPosition) { public static Splitter on(String separator) { checkArgument(!separator.isEmpty(), "The separator may not be the empty string."); if (separator.length() == 1) { - return Splitter.on(separator.charAt(0)); + return on(separator.charAt(0)); } return new Splitter( (splitter, toSplit) -> diff --git a/android/guava/src/com/google/common/cache/CacheBuilderSpec.java b/android/guava/src/com/google/common/cache/CacheBuilderSpec.java index 01524c0e4509..087b16ffdd08 100644 --- a/android/guava/src/com/google/common/cache/CacheBuilderSpec.java +++ b/android/guava/src/com/google/common/cache/CacheBuilderSpec.java @@ -168,7 +168,7 @@ public static CacheBuilderSpec parse(String cacheBuilderSpecification) { /** Returns a CacheBuilderSpec that will prevent caching. */ public static CacheBuilderSpec disableCaching() { // Maximum size of zero is one way to block caching - return CacheBuilderSpec.parse("maximumSize=0"); + return parse("maximumSize=0"); } /** Returns a CacheBuilder configured according to this instance's specification. */ diff --git a/android/guava/src/com/google/common/cache/LocalCache.java b/android/guava/src/com/google/common/cache/LocalCache.java index 7c79c901b9c3..3296cb2525fa 100644 --- a/android/guava/src/com/google/common/cache/LocalCache.java +++ b/android/guava/src/com/google/common/cache/LocalCache.java @@ -257,7 +257,7 @@ final class LocalCache extends AbstractMap implements ConcurrentMap< removalListener = builder.getRemovalListener(); removalNotificationQueue = (removalListener == NullListener.INSTANCE) - ? LocalCache.discardingQueue() + ? discardingQueue() : new ConcurrentLinkedQueue<>(); ticker = builder.getTicker(recordsTime()); @@ -1972,12 +1972,11 @@ static final class Segment extends ReentrantLock { valueReferenceQueue = map.usesValueReferences() ? new ReferenceQueue<>() : null; - recencyQueue = - map.usesAccessQueue() ? new ConcurrentLinkedQueue<>() : LocalCache.discardingQueue(); + recencyQueue = map.usesAccessQueue() ? new ConcurrentLinkedQueue<>() : discardingQueue(); - writeQueue = map.usesWriteQueue() ? new WriteQueue<>() : LocalCache.discardingQueue(); + writeQueue = map.usesWriteQueue() ? new WriteQueue<>() : discardingQueue(); - accessQueue = map.usesAccessQueue() ? new AccessQueue<>() : LocalCache.discardingQueue(); + accessQueue = map.usesAccessQueue() ? new AccessQueue<>() : discardingQueue(); } AtomicReferenceArray> newEntryArray(int size) { diff --git a/android/guava/src/com/google/common/collect/FluentIterable.java b/android/guava/src/com/google/common/collect/FluentIterable.java index 1dcd90e71f1a..98697e59b11e 100644 --- a/android/guava/src/com/google/common/collect/FluentIterable.java +++ b/android/guava/src/com/google/common/collect/FluentIterable.java @@ -321,7 +321,7 @@ Iterator get(int i) { */ @SuppressWarnings("EmptyList") // ImmutableList doesn't support nullable element types public static FluentIterable of() { - return FluentIterable.from(emptyList()); + return from(emptyList()); } /** @@ -401,7 +401,7 @@ public final FluentIterable cycle() { * @since 18.0 */ public final FluentIterable append(Iterable other) { - return FluentIterable.concat(getDelegate(), other); + return concat(getDelegate(), other); } /** @@ -413,7 +413,7 @@ public final FluentIterable append(Iterable other) { * @since 18.0 */ public final FluentIterable append(E... elements) { - return FluentIterable.concat(getDelegate(), asList(elements)); + return concat(getDelegate(), asList(elements)); } /** @@ -507,7 +507,7 @@ public final boolean allMatch(Predicate predicate) { */ public FluentIterable transformAndConcat( Function> function) { - return FluentIterable.concat(transform(function)); + return concat(transform(function)); } /** diff --git a/android/guava/src/com/google/common/collect/ImmutableListMultimap.java b/android/guava/src/com/google/common/collect/ImmutableListMultimap.java index 441b671e790d..15eefcca32ba 100644 --- a/android/guava/src/com/google/common/collect/ImmutableListMultimap.java +++ b/android/guava/src/com/google/common/collect/ImmutableListMultimap.java @@ -141,14 +141,14 @@ public static ImmutableListMultimap of() { /** Returns an immutable multimap containing a single entry. */ public static ImmutableListMultimap of(K k1, V v1) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); return builder.build(); } /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); return builder.build(); @@ -156,7 +156,7 @@ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2) { /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2, K k3, V v3) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -166,7 +166,7 @@ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2, K k3 /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -177,7 +177,7 @@ public static ImmutableListMultimap of( /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); diff --git a/android/guava/src/com/google/common/collect/ImmutableMultiset.java b/android/guava/src/com/google/common/collect/ImmutableMultiset.java index 34d98d6f5a3a..2f311fb36a44 100644 --- a/android/guava/src/com/google/common/collect/ImmutableMultiset.java +++ b/android/guava/src/com/google/common/collect/ImmutableMultiset.java @@ -189,7 +189,7 @@ public static ImmutableMultiset copyOf(Iterable elements) { } } ImmutableMultiset.Builder builder = - new ImmutableMultiset.Builder(Multisets.inferDistinctElements(elements)); + new ImmutableMultiset.Builder<>(Multisets.inferDistinctElements(elements)); builder.addAll(elements); return builder.build(); } @@ -210,7 +210,7 @@ private static ImmutableMultiset copyFromElements(E... elements) { static ImmutableMultiset copyFromEntries( Collection> entries) { - ImmutableMultiset.Builder builder = new ImmutableMultiset.Builder(entries.size()); + ImmutableMultiset.Builder builder = new ImmutableMultiset.Builder<>(entries.size()); for (Entry entry : entries) { builder.addCopies(entry.getElement(), entry.getCount()); } @@ -401,7 +401,7 @@ public int hashCode() { @J2ktIncompatible @Override Object writeReplace() { - return new EntrySetSerializedForm(ImmutableMultiset.this); + return new EntrySetSerializedForm<>(ImmutableMultiset.this); } @GwtIncompatible @@ -548,7 +548,7 @@ public Builder addCopies(E element, int occurrences) { return this; } if (buildInvoked) { - contents = new ObjectCountHashMap(contents); + contents = new ObjectCountHashMap<>(contents); isLinkedHash = false; } buildInvoked = false; @@ -571,12 +571,12 @@ public Builder addCopies(E element, int occurrences) { public Builder setCount(E element, int count) { requireNonNull(contents); // see the comment on the field if (count == 0 && !isLinkedHash) { - contents = new ObjectCountLinkedHashMap(contents); + contents = new ObjectCountLinkedHashMap<>(contents); isLinkedHash = true; // to preserve insertion order through deletions, we have to switch to an actual linked // implementation at least for now, but this should be a super rare case } else if (buildInvoked) { - contents = new ObjectCountHashMap(contents); + contents = new ObjectCountHashMap<>(contents); isLinkedHash = false; } buildInvoked = false; @@ -663,12 +663,12 @@ public ImmutableMultiset build() { if (isLinkedHash) { // we need ObjectCountHashMap-backed contents, with its keys and values array in direct // insertion order - contents = new ObjectCountHashMap(contents); + contents = new ObjectCountHashMap<>(contents); isLinkedHash = false; } buildInvoked = true; // contents is now ObjectCountHashMap, but still guaranteed to be in insertion order! - return new RegularImmutableMultiset(contents); + return new RegularImmutableMultiset<>(contents); } } diff --git a/android/guava/src/com/google/common/collect/ImmutableRangeMap.java b/android/guava/src/com/google/common/collect/ImmutableRangeMap.java index fe692ad91b91..7ff0480874e3 100644 --- a/android/guava/src/com/google/common/collect/ImmutableRangeMap.java +++ b/android/guava/src/com/google/common/collect/ImmutableRangeMap.java @@ -311,7 +311,7 @@ public ImmutableMap, V> asDescendingMapOfRanges() { @Override public ImmutableRangeMap subRangeMap(Range range) { if (checkNotNull(range).isEmpty()) { - return ImmutableRangeMap.of(); + return of(); } else if (ranges.isEmpty() || range.encloses(span())) { return this; } @@ -330,7 +330,7 @@ public ImmutableRangeMap subRangeMap(Range range) { KeyPresentBehavior.ANY_PRESENT, KeyAbsentBehavior.NEXT_HIGHER); if (lowerIndex >= upperIndex) { - return ImmutableRangeMap.of(); + return of(); } int off = lowerIndex; int len = upperIndex - lowerIndex; diff --git a/android/guava/src/com/google/common/collect/ImmutableSetMultimap.java b/android/guava/src/com/google/common/collect/ImmutableSetMultimap.java index b1c1e0170c2e..a6a599dc6f56 100644 --- a/android/guava/src/com/google/common/collect/ImmutableSetMultimap.java +++ b/android/guava/src/com/google/common/collect/ImmutableSetMultimap.java @@ -160,7 +160,7 @@ public static ImmutableSetMultimap of() { /** Returns an immutable multimap containing a single entry. */ public static ImmutableSetMultimap of(K k1, V v1) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); return builder.build(); } @@ -170,7 +170,7 @@ public static ImmutableSetMultimap of(K k1, V v1) { * an entry (according to {@link Object#equals}) after the first are ignored. */ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); return builder.build(); @@ -181,7 +181,7 @@ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2) { * an entry (according to {@link Object#equals}) after the first are ignored. */ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2, K k3, V v3) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -194,7 +194,7 @@ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2, K k3, */ public static ImmutableSetMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -208,7 +208,7 @@ public static ImmutableSetMultimap of( */ public static ImmutableSetMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -396,7 +396,7 @@ public Builder orderValuesBy(Comparator valueComparator) { @Override public ImmutableSetMultimap build() { if (builderMap == null) { - return ImmutableSetMultimap.of(); + return of(); } Collection>> mapEntries = builderMap.entrySet(); if (keyComparator != null) { diff --git a/android/guava/src/com/google/common/collect/ImmutableSortedMap.java b/android/guava/src/com/google/common/collect/ImmutableSortedMap.java index d198650cda16..6599ec1d4809 100644 --- a/android/guava/src/com/google/common/collect/ImmutableSortedMap.java +++ b/android/guava/src/com/google/common/collect/ImmutableSortedMap.java @@ -328,11 +328,7 @@ public static , V> ImmutableSortedMap of( V v8, K k9, V v9) { - /* - * This explicit type parameter works around what seems to be a javac bug in certain - * configurations: b/339186525#comment6 - */ - return ImmutableSortedMap.fromEntries( + return fromEntries( entryOf(k1, v1), entryOf(k2, v2), entryOf(k3, v3), diff --git a/android/guava/src/com/google/common/collect/ImmutableTable.java b/android/guava/src/com/google/common/collect/ImmutableTable.java index 9667c9639791..a8428da9e072 100644 --- a/android/guava/src/com/google/common/collect/ImmutableTable.java +++ b/android/guava/src/com/google/common/collect/ImmutableTable.java @@ -136,7 +136,7 @@ public static ImmutableTable copyOf( static ImmutableTable copyOf( Iterable> cells) { - ImmutableTable.Builder builder = ImmutableTable.builder(); + ImmutableTable.Builder builder = builder(); for (Cell cell : cells) { builder.put(cell); } diff --git a/android/guava/src/com/google/common/collect/Sets.java b/android/guava/src/com/google/common/collect/Sets.java index 3779a1d15d45..70ba96fb07df 100644 --- a/android/guava/src/com/google/common/collect/Sets.java +++ b/android/guava/src/com/google/common/collect/Sets.java @@ -1349,7 +1349,7 @@ NavigableSet unfiltered() { @Override public NavigableSet descendingSet() { - return Sets.filter(unfiltered().descendingSet(), predicate); + return filter(unfiltered().descendingSet(), predicate); } @Override diff --git a/android/guava/src/com/google/common/collect/Synchronized.java b/android/guava/src/com/google/common/collect/Synchronized.java index 914a0289b1fa..238db15b1e4c 100644 --- a/android/guava/src/com/google/common/collect/Synchronized.java +++ b/android/guava/src/com/google/common/collect/Synchronized.java @@ -1343,7 +1343,7 @@ public Iterator descendingIterator() { public NavigableSet descendingSet() { synchronized (mutex) { if (descendingSet == null) { - NavigableSet dS = Synchronized.navigableSet(delegate().descendingSet(), mutex); + NavigableSet dS = navigableSet(delegate().descendingSet(), mutex); descendingSet = dS; return dS; } @@ -1361,7 +1361,7 @@ public NavigableSet descendingSet() { @Override public NavigableSet headSet(E toElement, boolean inclusive) { synchronized (mutex) { - return Synchronized.navigableSet(delegate().headSet(toElement, inclusive), mutex); + return navigableSet(delegate().headSet(toElement, inclusive), mutex); } } @@ -1402,7 +1402,7 @@ public SortedSet headSet(E toElement) { public NavigableSet subSet( E fromElement, boolean fromInclusive, E toElement, boolean toInclusive) { synchronized (mutex) { - return Synchronized.navigableSet( + return navigableSet( delegate().subSet(fromElement, fromInclusive, toElement, toInclusive), mutex); } } @@ -1415,7 +1415,7 @@ public SortedSet subSet(E fromElement, E toElement) { @Override public NavigableSet tailSet(E fromElement, boolean inclusive) { synchronized (mutex) { - return Synchronized.navigableSet(delegate().tailSet(fromElement, inclusive), mutex); + return navigableSet(delegate().tailSet(fromElement, inclusive), mutex); } } @@ -1485,7 +1485,7 @@ NavigableMap delegate() { public NavigableSet descendingKeySet() { synchronized (mutex) { if (descendingKeySet == null) { - return descendingKeySet = Synchronized.navigableSet(delegate().descendingKeySet(), mutex); + return descendingKeySet = navigableSet(delegate().descendingKeySet(), mutex); } return descendingKeySet; } @@ -1582,7 +1582,7 @@ public Set keySet() { public NavigableSet navigableKeySet() { synchronized (mutex) { if (navigableKeySet == null) { - return navigableKeySet = Synchronized.navigableSet(delegate().navigableKeySet(), mutex); + return navigableKeySet = navigableSet(delegate().navigableKeySet(), mutex); } return navigableKeySet; } diff --git a/android/guava/src/com/google/common/collect/TreeMultiset.java b/android/guava/src/com/google/common/collect/TreeMultiset.java index 3fa4f7d85576..1b1560fa5ac9 100644 --- a/android/guava/src/com/google/common/collect/TreeMultiset.java +++ b/android/guava/src/com/google/common/collect/TreeMultiset.java @@ -930,8 +930,7 @@ AvlNode add( } private void recomputeMultiset() { - this.distinctElements = - 1 + TreeMultiset.distinctElements(left) + TreeMultiset.distinctElements(right); + this.distinctElements = 1 + distinctElements(left) + distinctElements(right); this.totalCount = elemCount + totalCount(left) + totalCount(right); } diff --git a/android/guava/src/com/google/common/graph/ImmutableGraph.java b/android/guava/src/com/google/common/graph/ImmutableGraph.java index 04188c8e23ba..3842183a4a39 100644 --- a/android/guava/src/com/google/common/graph/ImmutableGraph.java +++ b/android/guava/src/com/google/common/graph/ImmutableGraph.java @@ -195,7 +195,7 @@ public Builder putEdge(EndpointPair endpoints) { * Returns a newly-created {@code ImmutableGraph} based on the contents of this {@code Builder}. */ public ImmutableGraph build() { - return ImmutableGraph.copyOf(mutableGraph); + return copyOf(mutableGraph); } } } diff --git a/android/guava/src/com/google/common/graph/ImmutableNetwork.java b/android/guava/src/com/google/common/graph/ImmutableNetwork.java index 7dc108eefcd6..b94012b61615 100644 --- a/android/guava/src/com/google/common/graph/ImmutableNetwork.java +++ b/android/guava/src/com/google/common/graph/ImmutableNetwork.java @@ -234,7 +234,7 @@ public ImmutableNetwork.Builder addEdge(EndpointPair endpoints, E edge) * Builder}. */ public ImmutableNetwork build() { - return ImmutableNetwork.copyOf(mutableNetwork); + return copyOf(mutableNetwork); } } } diff --git a/android/guava/src/com/google/common/graph/ImmutableValueGraph.java b/android/guava/src/com/google/common/graph/ImmutableValueGraph.java index 6346e5fc5046..3671745d9aac 100644 --- a/android/guava/src/com/google/common/graph/ImmutableValueGraph.java +++ b/android/guava/src/com/google/common/graph/ImmutableValueGraph.java @@ -199,7 +199,7 @@ public ImmutableValueGraph.Builder putEdgeValue(EndpointPair endpoints, * Builder}. */ public ImmutableValueGraph build() { - return ImmutableValueGraph.copyOf(mutableValueGraph); + return copyOf(mutableValueGraph); } } } diff --git a/android/guava/src/com/google/common/hash/BloomFilter.java b/android/guava/src/com/google/common/hash/BloomFilter.java index 2da114920eed..0e14e9ec6f92 100644 --- a/android/guava/src/com/google/common/hash/BloomFilter.java +++ b/android/guava/src/com/google/common/hash/BloomFilter.java @@ -386,7 +386,7 @@ public int hashCode() { checkArgument(fpp > 0.0, "False positive probability (%s) must be > 0.0", fpp); checkArgument(fpp < 1.0, "False positive probability (%s) must be < 1.0", fpp); return Collector.of( - () -> BloomFilter.create(funnel, expectedInsertions, fpp), + () -> create(funnel, expectedInsertions, fpp), BloomFilter::put, (bf1, bf2) -> { bf1.putAll(bf2); diff --git a/android/guava/src/com/google/common/math/LongMath.java b/android/guava/src/com/google/common/math/LongMath.java index f3c7728b8ba9..ddab4a446fc8 100644 --- a/android/guava/src/com/google/common/math/LongMath.java +++ b/android/guava/src/com/google/common/math/LongMath.java @@ -830,7 +830,7 @@ public static long binomial(int n, int k) { } return result; } else { - int nBits = LongMath.log2(n, RoundingMode.CEILING); + int nBits = log2(n, RoundingMode.CEILING); long result = 1; long numerator = n--; diff --git a/android/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java b/android/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java index 35701bb5cf04..9a9939a773e0 100644 --- a/android/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java +++ b/android/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java @@ -129,7 +129,7 @@ protected Set> delegate() { @Override public Iterator> iterator() { - return UnmodifiableEntry.transformEntries(super.iterator()); + return transformEntries(super.iterator()); } @Override diff --git a/android/guava/src/com/google/common/reflect/Types.java b/android/guava/src/com/google/common/reflect/Types.java index 2ed16e82d655..172a2beb8d5d 100644 --- a/android/guava/src/com/google/common/reflect/Types.java +++ b/android/guava/src/com/google/common/reflect/Types.java @@ -125,7 +125,7 @@ class LocalClass {} // requireNonNull is safe because we're examining a type that's known to have a superclass. ParameterizedType parameterizedType = requireNonNull((ParameterizedType) subclass.getGenericSuperclass()); - for (ClassOwnership behavior : ClassOwnership.values()) { + for (ClassOwnership behavior : values()) { if (behavior.getOwnerType(LocalClass.class) == parameterizedType.getOwnerType()) { return behavior; } diff --git a/android/guava/src/com/google/common/util/concurrent/ClosingFuture.java b/android/guava/src/com/google/common/util/concurrent/ClosingFuture.java index c9ab486cd940..ff1a008f320d 100644 --- a/android/guava/src/com/google/common/util/concurrent/ClosingFuture.java +++ b/android/guava/src/com/google/common/util/concurrent/ClosingFuture.java @@ -824,7 +824,7 @@ public String toString() { public static AsyncClosingFunction withoutCloser(AsyncFunction function) { checkNotNull(function); - return (closer, input) -> ClosingFuture.from(function.apply(input)); + return (closer, input) -> from(function.apply(input)); } /** diff --git a/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java index d414d00c36b3..bdd8c033f018 100644 --- a/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java @@ -52,8 +52,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - CollectionTestSuiteBuilder.using( - new ReserializedCollectionGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedCollectionGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java index e5f22d730939..74f74e97ceed 100644 --- a/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java @@ -111,8 +111,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - ListTestSuiteBuilder.using( - new ReserializedListGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedListGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java index e239031bf7b8..07428ad1ed9d 100644 --- a/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/MapTestSuiteBuilder.java @@ -119,8 +119,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MapTestSuiteBuilder.using( - new ReserializedMapGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeReserializedMapFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " reserialized") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java index ed65a07c487d..933f19f3427c 100644 --- a/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java @@ -75,8 +75,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(SERIALIZABLE)) { derivedSuites.add( - SetTestSuiteBuilder.using( - new ReserializedSetGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedSetGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedCollectionFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java index 28b5572e974f..5178a29c6f99 100644 --- a/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/google/BiMapTestSuiteBuilder.java @@ -110,8 +110,7 @@ protected List createDerivedSuites( .createTestSuite()); if (!parentBuilder.getFeatures().contains(NoRecurse.INVERSE)) { derived.add( - BiMapTestSuiteBuilder.using( - new InverseBiMapGenerator(parentBuilder.getSubjectGenerator())) + using(new InverseBiMapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeInverseFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " inverse") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java index 1a8f7e3fd769..c74e8d340380 100644 --- a/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java @@ -113,8 +113,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MultimapTestSuiteBuilder.using( - new ReserializedMultimapGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMultimapGenerator(parentBuilder.getSubjectGenerator())) .withFeatures(computeReserializedMultimapFeatures(parentBuilder.getFeatures())) .named(parentBuilder.getName() + " reserialized") .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java index 0460b693280d..06df3f014e9e 100644 --- a/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/google/MultisetTestSuiteBuilder.java @@ -139,8 +139,7 @@ protected List createDerivedSuites( if (parentBuilder.getFeatures().contains(CollectionFeature.SERIALIZABLE)) { derivedSuites.add( - MultisetTestSuiteBuilder.using( - new ReserializedMultisetGenerator(parentBuilder.getSubjectGenerator())) + using(new ReserializedMultisetGenerator(parentBuilder.getSubjectGenerator())) .named(getName() + " reserialized") .withFeatures(computeReserializedMultisetFeatures(parentBuilder.getFeatures())) .suppressing(parentBuilder.getSuppressedTests()) diff --git a/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java b/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java index e806af0bd3ec..fc6f22b532b0 100644 --- a/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java +++ b/guava-testlib/src/com/google/common/collect/testing/google/SortedMultisetTestSuiteBuilder.java @@ -162,7 +162,7 @@ private TestSuite createSubMultisetSuite( E firstInclusive = samplesList.get(0); E lastInclusive = samplesList.get(samplesList.size() - 1); - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { @@ -244,7 +244,7 @@ private TestSuite createDescendingSuite(SortedMultisetTestSuiteBuilder parent features.remove(SERIALIZABLE); } - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { @@ -270,7 +270,7 @@ private TestSuite createReserializedSuite(SortedMultisetTestSuiteBuilder pare features.remove(SERIALIZABLE); features.remove(SERIALIZABLE_INCLUDING_VIEWS); - return SortedMultisetTestSuiteBuilder.using( + return using( new ForwardingTestMultisetGenerator(delegate) { @Override public SortedMultiset create(Object... entries) { diff --git a/guava-tests/test/com/google/common/collect/AbstractHashFloodingTest.java b/guava-tests/test/com/google/common/collect/AbstractHashFloodingTest.java index 1551f59cfaf6..f2355ec5a456 100644 --- a/guava-tests/test/com/google/common/collect/AbstractHashFloodingTest.java +++ b/guava-tests/test/com/google/common/collect/AbstractHashFloodingTest.java @@ -157,7 +157,7 @@ public String toString() { } static final QueryOp> MAP_GET = - QueryOp.create( + create( "Map.get", (map, key) -> { Object unused = map.get(key); @@ -165,7 +165,7 @@ public String toString() { Math::log); static final QueryOp> SET_CONTAINS = - QueryOp.create( + create( "Set.contains", (set, key) -> { boolean unused = set.contains(key); diff --git a/guava/src/com/google/common/base/Optional.java b/guava/src/com/google/common/base/Optional.java index da7aa8e25a13..e8d0cd43ff8c 100644 --- a/guava/src/com/google/common/base/Optional.java +++ b/guava/src/com/google/common/base/Optional.java @@ -117,7 +117,7 @@ public static Optional of(T reference) { * {@code Optional.ofNullable}. */ public static Optional fromNullable(@Nullable T nullableReference) { - return (nullableReference == null) ? Optional.absent() : new Present<>(nullableReference); + return nullableReference == null ? absent() : new Present<>(nullableReference); } /** diff --git a/guava/src/com/google/common/base/Splitter.java b/guava/src/com/google/common/base/Splitter.java index 796adf3291d0..e11b0dfa1029 100644 --- a/guava/src/com/google/common/base/Splitter.java +++ b/guava/src/com/google/common/base/Splitter.java @@ -165,7 +165,7 @@ int separatorEnd(int separatorPosition) { public static Splitter on(String separator) { checkArgument(!separator.isEmpty(), "The separator may not be the empty string."); if (separator.length() == 1) { - return Splitter.on(separator.charAt(0)); + return on(separator.charAt(0)); } return new Splitter( (splitter, toSplit) -> diff --git a/guava/src/com/google/common/cache/CacheBuilderSpec.java b/guava/src/com/google/common/cache/CacheBuilderSpec.java index 01524c0e4509..087b16ffdd08 100644 --- a/guava/src/com/google/common/cache/CacheBuilderSpec.java +++ b/guava/src/com/google/common/cache/CacheBuilderSpec.java @@ -168,7 +168,7 @@ public static CacheBuilderSpec parse(String cacheBuilderSpecification) { /** Returns a CacheBuilderSpec that will prevent caching. */ public static CacheBuilderSpec disableCaching() { // Maximum size of zero is one way to block caching - return CacheBuilderSpec.parse("maximumSize=0"); + return parse("maximumSize=0"); } /** Returns a CacheBuilder configured according to this instance's specification. */ diff --git a/guava/src/com/google/common/cache/LocalCache.java b/guava/src/com/google/common/cache/LocalCache.java index 4a90a7320b01..855c3feb1840 100644 --- a/guava/src/com/google/common/cache/LocalCache.java +++ b/guava/src/com/google/common/cache/LocalCache.java @@ -261,7 +261,7 @@ final class LocalCache extends AbstractMap implements ConcurrentMap< removalListener = builder.getRemovalListener(); removalNotificationQueue = (removalListener == NullListener.INSTANCE) - ? LocalCache.discardingQueue() + ? discardingQueue() : new ConcurrentLinkedQueue<>(); ticker = builder.getTicker(recordsTime()); @@ -1976,12 +1976,11 @@ static final class Segment extends ReentrantLock { valueReferenceQueue = map.usesValueReferences() ? new ReferenceQueue<>() : null; - recencyQueue = - map.usesAccessQueue() ? new ConcurrentLinkedQueue<>() : LocalCache.discardingQueue(); + recencyQueue = map.usesAccessQueue() ? new ConcurrentLinkedQueue<>() : discardingQueue(); - writeQueue = map.usesWriteQueue() ? new WriteQueue<>() : LocalCache.discardingQueue(); + writeQueue = map.usesWriteQueue() ? new WriteQueue<>() : discardingQueue(); - accessQueue = map.usesAccessQueue() ? new AccessQueue<>() : LocalCache.discardingQueue(); + accessQueue = map.usesAccessQueue() ? new AccessQueue<>() : discardingQueue(); } AtomicReferenceArray> newEntryArray(int size) { @@ -3501,7 +3500,7 @@ public LoadingValueReference() { } public LoadingValueReference(@Nullable ValueReference oldValue) { - this.oldValue = (oldValue == null) ? LocalCache.unset() : oldValue; + this.oldValue = (oldValue == null) ? unset() : oldValue; } @Override diff --git a/guava/src/com/google/common/collect/FluentIterable.java b/guava/src/com/google/common/collect/FluentIterable.java index e22749e482e2..e78c2d3250d5 100644 --- a/guava/src/com/google/common/collect/FluentIterable.java +++ b/guava/src/com/google/common/collect/FluentIterable.java @@ -314,7 +314,7 @@ Iterator get(int i) { */ @SuppressWarnings("EmptyList") // ImmutableList doesn't support nullable element types public static FluentIterable of() { - return FluentIterable.from(emptyList()); + return from(emptyList()); } /** @@ -394,7 +394,7 @@ public final FluentIterable cycle() { * @since 18.0 */ public final FluentIterable append(Iterable other) { - return FluentIterable.concat(getDelegate(), other); + return concat(getDelegate(), other); } /** @@ -406,7 +406,7 @@ public final FluentIterable append(Iterable other) { * @since 18.0 */ public final FluentIterable append(E... elements) { - return FluentIterable.concat(getDelegate(), asList(elements)); + return concat(getDelegate(), asList(elements)); } /** @@ -500,7 +500,7 @@ public final boolean allMatch(Predicate predicate) { */ public FluentIterable transformAndConcat( Function> function) { - return FluentIterable.concat(transform(function)); + return concat(transform(function)); } /** diff --git a/guava/src/com/google/common/collect/ImmutableListMultimap.java b/guava/src/com/google/common/collect/ImmutableListMultimap.java index c036c0cae318..5d7b7998d650 100644 --- a/guava/src/com/google/common/collect/ImmutableListMultimap.java +++ b/guava/src/com/google/common/collect/ImmutableListMultimap.java @@ -139,14 +139,14 @@ public static ImmutableListMultimap of() { /** Returns an immutable multimap containing a single entry. */ public static ImmutableListMultimap of(K k1, V v1) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); return builder.build(); } /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); return builder.build(); @@ -154,7 +154,7 @@ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2) { /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2, K k3, V v3) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -164,7 +164,7 @@ public static ImmutableListMultimap of(K k1, V v1, K k2, V v2, K k3 /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -175,7 +175,7 @@ public static ImmutableListMultimap of( /** Returns an immutable multimap containing the given entries, in order. */ public static ImmutableListMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5) { - ImmutableListMultimap.Builder builder = ImmutableListMultimap.builder(); + ImmutableListMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); diff --git a/guava/src/com/google/common/collect/ImmutableMultiset.java b/guava/src/com/google/common/collect/ImmutableMultiset.java index dda24625c11b..887489b9f8ad 100644 --- a/guava/src/com/google/common/collect/ImmutableMultiset.java +++ b/guava/src/com/google/common/collect/ImmutableMultiset.java @@ -664,7 +664,7 @@ Object readResolve() { for (int i = 0; i < elements.length; i++) { multiset.add(elements[i], counts[i]); } - return ImmutableMultiset.copyOf(multiset); + return copyOf(multiset); } @GwtIncompatible @J2ktIncompatible private static final long serialVersionUID = 0; diff --git a/guava/src/com/google/common/collect/ImmutableRangeMap.java b/guava/src/com/google/common/collect/ImmutableRangeMap.java index 7eda4ddd620c..670ab3c2dd54 100644 --- a/guava/src/com/google/common/collect/ImmutableRangeMap.java +++ b/guava/src/com/google/common/collect/ImmutableRangeMap.java @@ -328,7 +328,7 @@ public ImmutableMap, V> asDescendingMapOfRanges() { @Override public ImmutableRangeMap subRangeMap(Range range) { if (checkNotNull(range).isEmpty()) { - return ImmutableRangeMap.of(); + return of(); } else if (ranges.isEmpty() || range.encloses(span())) { return this; } @@ -347,7 +347,7 @@ public ImmutableRangeMap subRangeMap(Range range) { KeyPresentBehavior.ANY_PRESENT, KeyAbsentBehavior.NEXT_HIGHER); if (lowerIndex >= upperIndex) { - return ImmutableRangeMap.of(); + return of(); } int off = lowerIndex; int len = upperIndex - lowerIndex; diff --git a/guava/src/com/google/common/collect/ImmutableSet.java b/guava/src/com/google/common/collect/ImmutableSet.java index 4c408f59aff9..6c7a405eebb5 100644 --- a/guava/src/com/google/common/collect/ImmutableSet.java +++ b/guava/src/com/google/common/collect/ImmutableSet.java @@ -679,7 +679,7 @@ SetBuilderImpl copy() { @Override ImmutableSet build() { - return ImmutableSet.of(); + return of(); } } diff --git a/guava/src/com/google/common/collect/ImmutableSetMultimap.java b/guava/src/com/google/common/collect/ImmutableSetMultimap.java index 914b1c4a0dcb..5ab807178286 100644 --- a/guava/src/com/google/common/collect/ImmutableSetMultimap.java +++ b/guava/src/com/google/common/collect/ImmutableSetMultimap.java @@ -158,7 +158,7 @@ public static ImmutableSetMultimap of() { /** Returns an immutable multimap containing a single entry. */ public static ImmutableSetMultimap of(K k1, V v1) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); return builder.build(); } @@ -168,7 +168,7 @@ public static ImmutableSetMultimap of(K k1, V v1) { * an entry (according to {@link Object#equals}) after the first are ignored. */ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); return builder.build(); @@ -179,7 +179,7 @@ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2) { * an entry (according to {@link Object#equals}) after the first are ignored. */ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2, K k3, V v3) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -192,7 +192,7 @@ public static ImmutableSetMultimap of(K k1, V v1, K k2, V v2, K k3, */ public static ImmutableSetMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -206,7 +206,7 @@ public static ImmutableSetMultimap of( */ public static ImmutableSetMultimap of( K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5) { - ImmutableSetMultimap.Builder builder = ImmutableSetMultimap.builder(); + ImmutableSetMultimap.Builder builder = builder(); builder.put(k1, v1); builder.put(k2, v2); builder.put(k3, v3); @@ -394,7 +394,7 @@ public Builder orderValuesBy(Comparator valueComparator) { @Override public ImmutableSetMultimap build() { if (builderMap == null) { - return ImmutableSetMultimap.of(); + return of(); } Collection>> mapEntries = builderMap.entrySet(); if (keyComparator != null) { diff --git a/guava/src/com/google/common/collect/ImmutableSortedMap.java b/guava/src/com/google/common/collect/ImmutableSortedMap.java index 4d479f99fcc4..39fc257e7396 100644 --- a/guava/src/com/google/common/collect/ImmutableSortedMap.java +++ b/guava/src/com/google/common/collect/ImmutableSortedMap.java @@ -326,11 +326,7 @@ public static , V> ImmutableSortedMap of( V v8, K k9, V v9) { - /* - * This explicit type parameter works around what seems to be a javac bug in certain - * configurations: b/339186525#comment6 - */ - return ImmutableSortedMap.fromEntries( + return fromEntries( entryOf(k1, v1), entryOf(k2, v2), entryOf(k3, v3), diff --git a/guava/src/com/google/common/collect/ImmutableTable.java b/guava/src/com/google/common/collect/ImmutableTable.java index 43b2b23b4d46..25624cca6e20 100644 --- a/guava/src/com/google/common/collect/ImmutableTable.java +++ b/guava/src/com/google/common/collect/ImmutableTable.java @@ -135,7 +135,7 @@ public static ImmutableTable copyOf( static ImmutableTable copyOf( Iterable> cells) { - ImmutableTable.Builder builder = ImmutableTable.builder(); + ImmutableTable.Builder builder = builder(); for (Cell cell : cells) { builder.put(cell); } diff --git a/guava/src/com/google/common/collect/Sets.java b/guava/src/com/google/common/collect/Sets.java index 02f4fb04f5ec..f8fc8fbae1b0 100644 --- a/guava/src/com/google/common/collect/Sets.java +++ b/guava/src/com/google/common/collect/Sets.java @@ -1394,7 +1394,7 @@ NavigableSet unfiltered() { @Override public NavigableSet descendingSet() { - return Sets.filter(unfiltered().descendingSet(), predicate); + return filter(unfiltered().descendingSet(), predicate); } @Override diff --git a/guava/src/com/google/common/collect/Synchronized.java b/guava/src/com/google/common/collect/Synchronized.java index 00f7d12a3693..2376247fdaf5 100644 --- a/guava/src/com/google/common/collect/Synchronized.java +++ b/guava/src/com/google/common/collect/Synchronized.java @@ -1494,7 +1494,7 @@ public Iterator descendingIterator() { public NavigableSet descendingSet() { synchronized (mutex) { if (descendingSet == null) { - NavigableSet dS = Synchronized.navigableSet(delegate().descendingSet(), mutex); + NavigableSet dS = navigableSet(delegate().descendingSet(), mutex); descendingSet = dS; return dS; } @@ -1512,7 +1512,7 @@ public NavigableSet descendingSet() { @Override public NavigableSet headSet(E toElement, boolean inclusive) { synchronized (mutex) { - return Synchronized.navigableSet(delegate().headSet(toElement, inclusive), mutex); + return navigableSet(delegate().headSet(toElement, inclusive), mutex); } } @@ -1553,7 +1553,7 @@ public SortedSet headSet(E toElement) { public NavigableSet subSet( E fromElement, boolean fromInclusive, E toElement, boolean toInclusive) { synchronized (mutex) { - return Synchronized.navigableSet( + return navigableSet( delegate().subSet(fromElement, fromInclusive, toElement, toInclusive), mutex); } } @@ -1566,7 +1566,7 @@ public SortedSet subSet(E fromElement, E toElement) { @Override public NavigableSet tailSet(E fromElement, boolean inclusive) { synchronized (mutex) { - return Synchronized.navigableSet(delegate().tailSet(fromElement, inclusive), mutex); + return navigableSet(delegate().tailSet(fromElement, inclusive), mutex); } } @@ -1636,7 +1636,7 @@ NavigableMap delegate() { public NavigableSet descendingKeySet() { synchronized (mutex) { if (descendingKeySet == null) { - return descendingKeySet = Synchronized.navigableSet(delegate().descendingKeySet(), mutex); + return descendingKeySet = navigableSet(delegate().descendingKeySet(), mutex); } return descendingKeySet; } @@ -1733,7 +1733,7 @@ public Set keySet() { public NavigableSet navigableKeySet() { synchronized (mutex) { if (navigableKeySet == null) { - return navigableKeySet = Synchronized.navigableSet(delegate().navigableKeySet(), mutex); + return navigableKeySet = navigableSet(delegate().navigableKeySet(), mutex); } return navigableKeySet; } diff --git a/guava/src/com/google/common/collect/TreeMultiset.java b/guava/src/com/google/common/collect/TreeMultiset.java index da9d1898d192..1eb895aef8a0 100644 --- a/guava/src/com/google/common/collect/TreeMultiset.java +++ b/guava/src/com/google/common/collect/TreeMultiset.java @@ -942,8 +942,7 @@ AvlNode add( } private void recomputeMultiset() { - this.distinctElements = - 1 + TreeMultiset.distinctElements(left) + TreeMultiset.distinctElements(right); + this.distinctElements = 1 + distinctElements(left) + distinctElements(right); this.totalCount = elemCount + totalCount(left) + totalCount(right); } diff --git a/guava/src/com/google/common/graph/ImmutableGraph.java b/guava/src/com/google/common/graph/ImmutableGraph.java index 04188c8e23ba..3842183a4a39 100644 --- a/guava/src/com/google/common/graph/ImmutableGraph.java +++ b/guava/src/com/google/common/graph/ImmutableGraph.java @@ -195,7 +195,7 @@ public Builder putEdge(EndpointPair endpoints) { * Returns a newly-created {@code ImmutableGraph} based on the contents of this {@code Builder}. */ public ImmutableGraph build() { - return ImmutableGraph.copyOf(mutableGraph); + return copyOf(mutableGraph); } } } diff --git a/guava/src/com/google/common/graph/ImmutableNetwork.java b/guava/src/com/google/common/graph/ImmutableNetwork.java index 7dc108eefcd6..b94012b61615 100644 --- a/guava/src/com/google/common/graph/ImmutableNetwork.java +++ b/guava/src/com/google/common/graph/ImmutableNetwork.java @@ -234,7 +234,7 @@ public ImmutableNetwork.Builder addEdge(EndpointPair endpoints, E edge) * Builder}. */ public ImmutableNetwork build() { - return ImmutableNetwork.copyOf(mutableNetwork); + return copyOf(mutableNetwork); } } } diff --git a/guava/src/com/google/common/graph/ImmutableValueGraph.java b/guava/src/com/google/common/graph/ImmutableValueGraph.java index 6346e5fc5046..3671745d9aac 100644 --- a/guava/src/com/google/common/graph/ImmutableValueGraph.java +++ b/guava/src/com/google/common/graph/ImmutableValueGraph.java @@ -199,7 +199,7 @@ public ImmutableValueGraph.Builder putEdgeValue(EndpointPair endpoints, * Builder}. */ public ImmutableValueGraph build() { - return ImmutableValueGraph.copyOf(mutableValueGraph); + return copyOf(mutableValueGraph); } } } diff --git a/guava/src/com/google/common/hash/BloomFilter.java b/guava/src/com/google/common/hash/BloomFilter.java index e58c1ec58fce..d56f8f665b68 100644 --- a/guava/src/com/google/common/hash/BloomFilter.java +++ b/guava/src/com/google/common/hash/BloomFilter.java @@ -396,7 +396,7 @@ public int hashCode() { checkArgument(fpp > 0.0, "False positive probability (%s) must be > 0.0", fpp); checkArgument(fpp < 1.0, "False positive probability (%s) must be < 1.0", fpp); return Collector.of( - () -> BloomFilter.create(funnel, expectedInsertions, fpp), + () -> create(funnel, expectedInsertions, fpp), BloomFilter::put, (bf1, bf2) -> { bf1.putAll(bf2); diff --git a/guava/src/com/google/common/math/LongMath.java b/guava/src/com/google/common/math/LongMath.java index f3c7728b8ba9..ddab4a446fc8 100644 --- a/guava/src/com/google/common/math/LongMath.java +++ b/guava/src/com/google/common/math/LongMath.java @@ -830,7 +830,7 @@ public static long binomial(int n, int k) { } return result; } else { - int nBits = LongMath.log2(n, RoundingMode.CEILING); + int nBits = log2(n, RoundingMode.CEILING); long result = 1; long numerator = n--; diff --git a/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java b/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java index 35701bb5cf04..9a9939a773e0 100644 --- a/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java +++ b/guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java @@ -129,7 +129,7 @@ protected Set> delegate() { @Override public Iterator> iterator() { - return UnmodifiableEntry.transformEntries(super.iterator()); + return transformEntries(super.iterator()); } @Override diff --git a/guava/src/com/google/common/reflect/Types.java b/guava/src/com/google/common/reflect/Types.java index 0e55c091c780..7bb9bc6c1adc 100644 --- a/guava/src/com/google/common/reflect/Types.java +++ b/guava/src/com/google/common/reflect/Types.java @@ -125,7 +125,7 @@ class LocalClass {} // requireNonNull is safe because we're examining a type that's known to have a superclass. ParameterizedType parameterizedType = requireNonNull((ParameterizedType) subclass.getGenericSuperclass()); - for (ClassOwnership behavior : ClassOwnership.values()) { + for (ClassOwnership behavior : values()) { if (behavior.getOwnerType(LocalClass.class) == parameterizedType.getOwnerType()) { return behavior; } diff --git a/guava/src/com/google/common/util/concurrent/ClosingFuture.java b/guava/src/com/google/common/util/concurrent/ClosingFuture.java index b9fc3055b7a4..2b5e6ce9f8e0 100644 --- a/guava/src/com/google/common/util/concurrent/ClosingFuture.java +++ b/guava/src/com/google/common/util/concurrent/ClosingFuture.java @@ -829,7 +829,7 @@ public String toString() { public static AsyncClosingFunction withoutCloser(AsyncFunction function) { checkNotNull(function); - return (closer, input) -> ClosingFuture.from(function.apply(input)); + return (closer, input) -> from(function.apply(input)); } /**