From 5e8d940563652d7b1927e92739247c457b87e5e1 Mon Sep 17 00:00:00 2001 From: mukunda katta Date: Sun, 19 Apr 2026 15:34:32 -0700 Subject: [PATCH] fix(vertex): append path for custom base_url requests --- google/genai/_api_client.py | 13 ++++++++----- google/genai/tests/client/test_client_requests.py | 9 ++++++--- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/google/genai/_api_client.py b/google/genai/_api_client.py index bb9865cc4..155fd5154 100644 --- a/google/genai/_api_client.py +++ b/google/genai/_api_client.py @@ -1224,11 +1224,14 @@ def _build_request( base_url, versioned_path, ) - elif( - self.custom_base_url - and patched_http_options.base_url_resource_scope == ResourceScope.COLLECTION - ): - url = join_url_path(base_url, path) + elif self.custom_base_url: + if ( + patched_http_options.base_url_resource_scope + == ResourceScope.COLLECTION + ): + url = join_url_path(base_url, path) + else: + url = join_url_path(base_url, versioned_path) if self.api_key and self.api_key.startswith('auth_tokens/'): raise EphemeralTokenAPIKeyError( diff --git a/google/genai/tests/client/test_client_requests.py b/google/genai/tests/client/test_client_requests.py index 4bbc35492..436bfc2ec 100644 --- a/google/genai/tests/client/test_client_requests.py +++ b/google/genai/tests/client/test_client_requests.py @@ -214,8 +214,11 @@ def test_build_request_with_custom_base_url_no_env_vars(monkeypatch): build_test_client_no_env_vars(monkeypatch).models._api_client ) request = request_client._build_request( - 'GET', - 'test/path', + 'POST', + 'publishers/google/models/gemini-2.5-flash-image:generateContent', {'key': 'value'}, ) - assert request.url == 'https://custom-base-url.com' \ No newline at end of file + assert request.url == ( + 'https://custom-base-url.com/v1beta1/' + 'publishers/google/models/gemini-2.5-flash-image:generateContent' + )