alicorn updates#204
Draft
carylwyatt wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The good news is that this is working locally except for some of the imgsrv parts. 🙃
I had to move around some files and change the references to those files since we don't use the
commonrepo anymore.The gulp build (
gulp runbuilds everything) spits out a bunch of sass warnings, but I can probably clean up the egregious ones of those (the pages that are loading have a weird green tint to them?). I removed some ancient polyfills because this is 2026 and those things are baseline now.Here's an example of an imgsrv image request that was successful next to one that gave a 500 error. I haven't looked too far into that issue.