[node-ws] "injectWebSocket" drops the env parameter for app.fetch

[PeterZhenhh]

Which middleware has the bug?

@hono/node-ws

What version of the middleware?

1.3.0

What version of Hono are you using?

4.11.4

What runtime/platform is your app running on? (with version if possible)

Node.js 22.19.0

What steps can reproduce the bug?

Server:

// index.js
import { createNodeWebSocket } from '@hono/node-ws'
import { serve } from '@hono/node-server'
import app from './base.js'

const { injectWebSocket } = createNodeWebSocket({ app })
const server = serve({
    port: 8080,
    fetch: async (request) => {
        let env = {
            customEnv: '1'
        }
        return app.fetch(request, env)
    }
}, (info) => {
    console.log(
        `Server listening on http://${info.address}:${info.port}`
    )
})
injectWebSocket(server)

// base.js
import { Hono } from 'hono'

const app = new Hono()
app.all("*", async (c) => {
  console.log(c.env.customEnv); // undefined, should be '1'
  return c.text("OK")
})

export default app

Client:

new WebSocket("ws://127.0.0.1:8080")

What is the expected behavior?

console.log(c.env.customEnv) should be '1'

What do you see instead?

No response

Additional information

No response

[PeterZhenhh]

#1733

[PeterZhenhh]

I managed to implement it, but all websocket connection use the same "env" , so sometimes c.env.inbound.something===undefined instead of 1. How to resolve?

// index.js
import { createNodeWebSocket } from '@hono/node-ws'
import { serve } from '@hono/node-server'
import app from './base.js'

let env = {}
const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({ app, env })

const server = serve({
    port: 8080,
    fetch: async (request) => {
        const ctxEnv = {
            ...process.env,
            inbound: { ip: socket.remoteAddress, something: undefined },
            upgradeWebSocket: upgradeWebSocket
        }
        return app.fetch(request, ctxEnv)
    }
}, ({ address, family, port }) => {
    injectWebSocket(server)
    console.log(
        `Server listening on http://${address}:${port}`
    )
})

server.on("connection", (socket) => {
    const newEnv = {
        ...process.env,
        inbound: { ip: socket.remoteAddress, something: undefined },
        upgradeWebSocket: upgradeWebSocket
    }
    Object.assign(env, newEnv)
})

// base.js
import { Hono } from 'hono'

const app = new Hono()
app.all("*", async (c, next) => {

    c.env.inbound.something = 1
    await fetch("https://xxx.com")
    // maybe failed when ws because Object.assign during fetch, how to resolve?
    c.env.inbound.something === undefined //true

    if (c.req.header("upgrade") !== "websocket") {
        return c.text("Non ws")
    } else {
        let ws = c.env.upgradeWebSocket((c) => ({
            onMessage(data, ws) {
                ws.send(data.data)
            }
        }))
        return ws(c, next)
    }
})
export default app