stimulus help needed

[maelle]

@szhorvat in 55b424b

I was too fast 😅

For pseudo_diameter_impl() we obtain

  if (is.null(weights) && "weight" %in% edge_attr_names(%I1%)) {
    weights <- E(%I1%)$weight
  }
  if (!is.null(weights) && any(!is.na(weights))) {
    weights <- as.numeric(weights)
  } else {
    weights <- NULL
  }

Which I don't understand as we have

rigraph/src/vendor/cigraph/interfaces/functions.yaml

Line 1091 in 55b424b

DEPS: weights ON graph

What did I miss?

It also happens for layout_drl_impl(), layout_drl_3d_impl().

[maelle]

I might have fixed it in add1951

• missing DEPS for layout_drl_impl(), layout_drl_3d_impl() -- should I make a PR to the C core, if so which branch?
• There was a DEPS in the configuration for Stimulus that is only in the R package. I thought the two DEPS, the one from the C core vendored files and the one from the R specific config files, would be merged but it seems that instead the DEPS from the R side takes precedence. Is that so?

[szhorvat]

missing DEPS for layout_drl_impl(), layout_drl_3d_impl() -- should I make a PR to the C core, if so which branch?

igraph/igraph@4710175

No more updates for the 0.10.x series, there's no branch for that currently ...

• it seems that instead the DEPS from the R side takes precedence. Is that so?

I think so

[maelle]

Thank you. Ok so this will be fixed in b-next when the next branch incorporates the next changes from igraph core, is that correct? cc @krlmlr