Feature/missing hana tests by awildturtok · Pull Request #3886 · ingef/conquery

awildturtok · 2026-05-05T14:30:03Z

No description provided.

thoniTUB

Hier werden viele Tests gelöscht, ist das korrekt?

thoniTUB · 2026-05-06T08:46:36Z

+		// Would prefer this to be `is not null`, but hana does not support that for fields
+		Field<String> isResolved = innerPrimaryColumn.as(IS_RESOLVED_ALIAS);


Warum kein boolean mehr und muss dann nicht auch das SQL Beispiel aus dem Kommentar angepasst werden?

steht doch im Kommentar direkt drüber? Ich hab keine Syntax / konstrukt gefunden die für Hana funktioniert (Also einfach is not null meckert hana obwohl es eigentlich eine gültige Hana Expression ist). Ich schaue mal, ob ein case-when funktioniert.

Habs über case-when gelöst. Danke für den Kommentar! 🙏

# Conflicts: # backend/src/test/resources/tests/aggregator/COUNT_QUARTERS_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/COUNT_QUARTERS_AGGREGATOR/content.csv # backend/src/test/resources/tests/aggregator/DURATION_SUM_AGGREGATOR/DURATION_SUM.test.json # backend/src/test/resources/tests/aggregator/DURATION_SUM_DISTINCT_AGGREGATOR/DURATION_SUM.test.json # backend/src/test/resources/tests/aggregator/EVENT_DATE_AGGREGATOR/EVENT_DATE_AGGREGATOR_NO_RESTRICTION.test.json # backend/src/test/resources/tests/aggregator/EVENT_DATE_AGGREGATOR/EVENT_DATE_AGGREGATOR_RESTRICTION.test.json # backend/src/test/resources/tests/aggregator/EXISTS_AGGREGATOR/NUMBER.test.json # backend/src/test/resources/tests/aggregator/EXISTS_AGGREGATOR_OR/NUMBER.test.json # backend/src/test/resources/tests/aggregator/FIRST_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/FLAGS_AGGREGATOR/FLAGS_AGGREGATOR.test.json # backend/src/test/resources/tests/aggregator/LAST_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/DISTINCT/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/DISTINCT_MULTI/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/FIRST/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/FIRST_MULTI/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/QUARTER_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/RANDOM_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT/SIMPLE.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT_MULTI/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/FIRST/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/FIRST/SIMPLE.test.json

thoniTUB

habe nur kleinigkeiten angemerkt :)

thoniTUB · 2026-05-20T14:48:48Z

+				(this.functionProvider.getMinDateExpression()),
+				(this.functionProvider.getMaxDateExpression()),


Suggested change

(this.functionProvider.getMinDateExpression()),

(this.functionProvider.getMaxDateExpression()),

this.functionProvider.getMinDateExpression(),

this.functionProvider.getMaxDateExpression(),

thoniTUB · 2026-05-20T14:51:35Z

 		Selects preprocessingSelects = Selects.builder()
 											  .ids(tableContext.getIds())
-											  .validityDate(tableContext.getValidityDate())
+											  .validityDate(Optional.of(tableContext.getValidityDate()))


Wird das Optional-packing weiter unten sinnvoll? Optionals sollte man eher bei Rückgabewerten nutzen nicht als member oder Argument

thoniTUB · 2026-05-20T14:55:14Z

+		// Since coalesce makes Clickhouse certain, that the field is not nullable, it will do silly stuff with it down the line:
+		// missing values (for example in outer-joins) will be coerced to 0 = 01-01-1970, which is clearly not correct
+		// Therefore we tag the values as Nullable again to make Clickhouse show some respect


thoniTUB · 2026-05-20T14:56:12Z

+		Field<Date> lowerBound = when(validityDateRange.getStart().lessThan(restriction.getStart()), restriction.getStart())
+				.otherwise(validityDateRange.getStart());
+
+		Field<Date> maxDate = getMinDateExpression(); // we want to add +1 day to the end date - except when it's the max date already


Wo ist das +1 von dem im Kommentar geschrieben ist?

thoniTUB · 2026-05-20T15:00:53Z

+@Slf4j
+public class ClickhouseSqlIntegrationTests extends IntegrationTests {
+
+	// SAP does not provide more than 1 image and on an update, the earlier image is deleted from dockerhub, thus latest tag is fine


Der Kommentar trifft nicht auf CH zu oder? Ich würde hier schon ein bestimmtes Image nehmen

thoniTUB · 2026-05-20T15:01:54Z

+public class ClickhouseSqlIntegrationTests extends IntegrationTests {
+
+	// SAP does not provide more than 1 image and on an update, the earlier image is deleted from dockerhub, thus latest tag is fine
+	private final static DockerImageName IMAGE_TAGE = DockerImageName.parse("clickhouse/clickhouse-server");


Suggested change

private final static DockerImageName IMAGE_TAGE = DockerImageName.parse("clickhouse/clickhouse-server");

private final static DockerImageName IMAGE_TAG = DockerImageName.parse("clickhouse/clickhouse-server");

thoniTUB · 2026-05-20T15:05:47Z

-6,2012-01-01,"m"
-6,2012-01-01,"f"


Ist das in den Datenbanken nicht deterministisch welcher wert genommen wird?

awildturtok added 2 commits April 29, 2026 16:47

change filter tests to fit Hana schema

7041282

More edits to tests so they work with HANA

7fa0a10

awildturtok requested a review from thoniTUB as a code owner May 5, 2026 14:30

awildturtok added 8 commits May 6, 2026 09:34

first impl of Clickhouse connection

bd28e6f

first impl of Clickhouse connection

8c59703

properly skip disabled tests

3d30f55

fix env variable names

7f67a0f

All Clickhouse zeszs green!

9439eed

enables and fixes even more tests for CH

330947b

fixes pg test

d276ebf

fixes undefined behaviour

6b15d52

thoniTUB reviewed May 6, 2026

View reviewed changes

awildturtok added 5 commits May 6, 2026 12:30

some naming conflicts in tests

0e22746

fixes form tests

056e535

adds injection for SelectConverters

e6e3b77

fixes all SQL tests

59832b1

awildturtok force-pushed the feature/missing-hana-tests branch from 98afbcc to 59832b1 Compare May 18, 2026 14:27

Fixes access pattern for CBlock span calculation

5eef162

awildturtok mentioned this pull request May 19, 2026

Feature/ch support #3885

Closed

Merge branch 'develop' into feature/missing-hana-tests

49dd50d

thoniTUB approved these changes May 20, 2026

View reviewed changes

		// Would prefer this to be `is not null`, but hana does not support that for fields
		Field<String> isResolved = innerPrimaryColumn.as(IS_RESOLVED_ALIAS);

		(this.functionProvider.getMinDateExpression()),
		(this.functionProvider.getMaxDateExpression()),

	private final static DockerImageName IMAGE_TAGE = DockerImageName.parse("clickhouse/clickhouse-server");
	private final static DockerImageName IMAGE_TAG = DockerImageName.parse("clickhouse/clickhouse-server");

		6,2012-01-01,"m"
		6,2012-01-01,"f" No newline at end of file

Conversation

awildturtok commented May 5, 2026

Uh oh!

thoniTUB left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

awildturtok May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thoniTUB left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

awildturtok May 6, 2026 •

edited

Loading