Pitch Bending Issue?

[ValHam1]

An issue in terms of the pitch (mainly seen at the end of vibrato, from my experience) seems to affect certain tracks from the Mega Man Battle Network series, though Song 0020 (A Serious Mission) in Mega Man Battle Network 2 demonstrates this perfectly. More information will be given if requested.

[ipatix]

I think I know what the problem is, and that is a situation that agbplay intentionally handles differently.

Imagine the following case:

• A note starts playing
• A series of pitch bends is a applies to gradually pitch down the note
• shortly afterwards, the note is relased (i.e. will fade out over a few ticks)
• Immediately after the release, pitch bend is set to 0 and a new note starts playing normally

The problem is: How do we handle the first pitched down note? Do we still apply the "pitch reset to 0" to it or not? In most cases, it would be the right choice to not apply it, because it will briefly cause a pitch glitch in the first note (which is fading out). However for e.g. and LFO, you'd want to keep applying it, because it may suddenly (like in your example) the pitch to stay stuck at an undesirable point, once the note is released.

A possibility would be to continue applying LFO while skipping regular pitch bends. However, this will once again cause other issues, because the LFO will sometimes force reset (when LFODL command is being used). That's not the case with MP2K Neo, which appears to use an LFO per channel rather than per track.

I'll have to think about this. Currently I don't have a good idea on how to fix this with a one-fits-all solution.