Skip to content

fix(test): repair binance pipeline imports#870

Merged
jackwener merged 1 commit intojackwener:mainfrom
Astro-Han:fix-binance-pipeline-import
Apr 8, 2026
Merged

fix(test): repair binance pipeline imports#870
jackwener merged 1 commit intojackwener:mainfrom
Astro-Han:fix-binance-pipeline-import

Conversation

@Astro-Han
Copy link
Copy Markdown
Contributor

@Astro-Han Astro-Han commented Apr 8, 2026

Description

Fix the unrelated post-merge CI failure that surfaced on PR #834 after merging main.

This PR is intentionally scoped to src/clis/binance/commands.test.ts only:

  • update the stale pipeline import to the current entrypoint, ../../pipeline/index.js
  • restore the mocked Response fields read by stepFetch()
  • cast executePipeline() results locally in the test to satisfy strict TypeScript

Related issue:
PR #834 post-merge CI regression, separate from the unified capture scope.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🌐 New site adapter
  • 📝 Documentation
  • ♻️ Refactor
  • 🔧 CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Documentation (if adding/modifying an adapter)

  • Added doc page under docs/adapters/ (if new adapter)
  • Updated docs/adapters/index.md table (if new adapter)
  • Updated sidebar in docs/.vitepress/config.mts (if new adapter)
  • Updated README.md / README.zh-CN.md when command discoverability changed
  • Used positional args for the command's primary subject unless a named flag is clearly better
  • Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

Relevant verification run locally:

npx tsc --noEmit
PASS

npx vitest run src/clis/binance/commands.test.ts
PASS, 3 tests

npx vitest run src/ --reporter=verbose --shard=2/2
PASS, 22 files, 196 tests passed, 1 skipped

npm run build
PASS

bun vitest run src/clis/binance/commands.test.ts
PASS, 3 tests

npm test
PASS, 45 files, 549 tests passed, 1 skipped

npm run test:adapter
FAIL, unrelated existing failure in clis/douyin/_shared/creation-id.test.ts
AssertionError: expected 99 to be 100

@jackwener jackwener merged commit 79fb082 into jackwener:main Apr 8, 2026
11 checks passed
@Astro-Han Astro-Han deleted the fix-binance-pipeline-import branch April 8, 2026 06:35
@jackwener jackwener mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants