Catch up with CLJS 1.10.520

[borkdude]

There have been several significant improvements and fixes to clojure.spec in CLJS 1.10.516.
Most of them are listed here:
https://github.com/borkdude/speculative/blob/master/doc/issues.md#fixed-and-released

[arichiardi]

I have some concern here in regards to expound - we are using orchestra instead of vanilla spec here for instrument because expound was not working on 1.10.439.

I can help with QA-ing things 😄

[jeaye]

I would really appreciate some help with this, if you guys are up for it. I've spoken a bit with @bhb about the breaking changes in CLJS and ended up reverting some bits so orchestra and expound could continue working together (since they're love & marriage, as far as I'm concerned). Ideally we can move both them forward together.

[borkdude]

#42 should make co-developing new features in orchestra + expound easier.

[borkdude]

Another suggestion:

It's possible to support older versions of CLJS via *clojurescript-version* and goog.string/compareVersions. Maybe expound could leverage this.

Example: https://github.com/borkdude/speculative/blob/master/src/speculative/specs.cljc#L9

[bhb]

I was hoping the "Improved Exception Messages and Printing" fixes would fix compatibilities with Expound, but my initial testing indicates that this is only partially fixed. I'll have more time to dig in this weekend.

[arichiardi]

I have to confirm, kind of taking back what I have said on Slack. I receive now as instrumentation error that does not contain the ex-data when there is a failure and cljs.spec.test.alpha is used.

On the other end, the latest orchestra does its job perfectly on orchestra/instrument and I correctly both data and expound output.

[borkdude]

Maybe make a JIRA issue about this in CLJS?
You could submit Orchestra and Expound to https://github.com/cljs-oss/canary so it will be tested automatically and thoroughly.

[bhb]

Something like https://dev.clojure.org/jira/browse/CLJS-2913 ? ;)

[bhb]

But yes, I will make a follow up JIRA once I have isolated a minimal repro 😄

[bhb]

@arichiardi There are a lot of moving parts here. Can you post a repro including CLJS version, CLJ version, spec version, and if you are calling a function or a macro?

[bhb]

https://dev.clojure.org/jira/browse/CLJS-3050

[bhb]

You could submit Orchestra and Expound to https://github.com/cljs-oss/canary so it will be tested automatically and thoroughly.

This is a good idea in general, but wouldn't have caught the particular bug I know about, because the bug is that the REPL doesn't call expound (or any custom printer) correctly. I suppose expound could do some acrobatics to test the REPL layer, but that seems out of scope?

[borkdude]

There seem to be tests around CLI usage here: https://github.com/clojure/clojurescript/blob/master/src/test/cljs_cli/cljs_cli/test.clj
So the patch for CLJS-3050 could probably add a test there?

[bhb]

@borkdude That's a good point.

To summarize the situation with 1.10.516 and Expound

• 1.10.516 fixes one the two known issues in 1.10.439
• There is one new minor incompatibility, but it's in a more obscure feature of Expound
• I'll release 0.7.3 soonish to address the minor regression

I'll add some new documentation on Expound/CLJS compat

https://github.com/bhb/expound/blob/078673b8c5bb42f3bcc9a8c2abf53d945d77efdb/doc/compatibility.md

[borkdude]

From the compatibility matrix on master I understand that expound works with clj 1.10 + 1.10.516 equally well as it did with 1.0 + 1.10.349?