Skip to content

wip: upgrade to JSON 1.4#99

Draft
pfitzseb wants to merge 1 commit intomainfrom
sp/json-1-4
Draft

wip: upgrade to JSON 1.4#99
pfitzseb wants to merge 1 commit intomainfrom
sp/json-1-4

Conversation

@pfitzseb
Copy link
Copy Markdown
Member

No description provided.

@davidanthoff
Copy link
Copy Markdown
Member

This would be great! But also, we'd have to find a way to still have it work on Julia 1.0, i.e. the package here needs to support both JSON 0.21.4 and the newer versions...

Different questions: do you know if JSON.jl in its current form is amendable to static compilation? That would be a major benefit...

@pfitzseb
Copy link
Copy Markdown
Member Author

This will also pull in a bunch more dependencies, which is a bit annoying (but something we can handle). It shouldn't be that hard to support both the 0.20 API and this though, I'll play around with that a bit more.

There's also https://github.com/JuliaIO/JSON.jl/tree/master/vendor, but the LS is at least somewhat performance sensitive, so maybe it's not the best idea to use that.

Different questions: do you know if JSON.jl in its current form is amendable to static compilation? That would be a major benefit...

Reasonably sure it isn't, although JSONX should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants