Run Go binding tests under -race#266
Merged
Merged
Conversation
Possible since #265 removed the uintptr->pointer handle conversion that checkptr fataled on. Beyond data races, -race enables checkptr, turning any future integer-handle-in-pointer-slot regression into a deterministic fatal at the conversion site instead of a rare GC crash (UI-1813). The suite goes from ~0.5s to ~1.6s; race-instrumented artifacts land in the Go build cache, so CI steady state pays a couple of seconds.
George-Payne
added
tooling
PR Summary by QodoRun Go binding tests with -race via justfile recipe
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #265: run the Go binding tests under
-race, now that the checkptr-illegal handle conversion is gone.bindings/go/justfile--raceadded to thetestrecipe. CI inherits it viajust _test->bindings::test->go::test, no workflow changes. Beyond data races,-raceenables checkptr, so a future integer-handle-in-pointer-slot regression fatals deterministically at the conversion site instead of crashing the GC once in a blue moon (UI-1813). Measured cost: the suite goes from ~0.5s to ~1.6s, with race-instrumented artifacts cached by setup-go, so steady-state CI pays a couple of seconds.