-
Notifications
You must be signed in to change notification settings - Fork 147
Add support for resolving BIP 353 Human-Readable Names #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tnull
merged 4 commits into
lightningdevkit:main
from
chuksys:add-support-for-resolving-hrns
Apr 21, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |
| //! Objects for configuring the node. | ||
|
|
||
| use std::fmt; | ||
| use std::str::FromStr; | ||
| use std::time::Duration; | ||
|
|
||
| use bitcoin::secp256k1::PublicKey; | ||
|
|
@@ -128,6 +129,7 @@ pub(crate) const LNURL_AUTH_TIMEOUT_SECS: u64 = 15; | |
| /// | `anchor_channels_config` | Some(..) | | ||
| /// | `route_parameters` | None | | ||
| /// | `tor_config` | None | | ||
| /// | `hrn_config` | HumanReadableNamesConfig::default() | | ||
| /// | ||
| /// See [`AnchorChannelsConfig`] and [`RouteParametersConfig`] for more information regarding their | ||
| /// respective default values. | ||
|
|
@@ -199,6 +201,10 @@ pub struct Config { | |
| /// | ||
| /// **Note**: If unset, connecting to peer OnionV3 addresses will fail. | ||
| pub tor_config: Option<TorConfig>, | ||
| /// Configuration options for Human-Readable Names ([BIP 353]). | ||
| /// | ||
| /// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki | ||
| pub hrn_config: HumanReadableNamesConfig, | ||
| } | ||
|
|
||
| impl Default for Config { | ||
|
|
@@ -214,6 +220,62 @@ impl Default for Config { | |
| tor_config: None, | ||
| route_parameters: None, | ||
| node_alias: None, | ||
| hrn_config: HumanReadableNamesConfig::default(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Configuration options for how our node resolves Human-Readable Names (BIP 353). | ||
| /// | ||
| /// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki | ||
| #[derive(Debug, Clone)] | ||
| #[cfg_attr(feature = "uniffi", derive(uniffi::Enum))] | ||
| pub enum HRNResolverConfig { | ||
| /// Use [bLIP-32] to ask other nodes to resolve names for us. | ||
| /// | ||
| /// [bLIP-32]: https://github.com/lightning/blips/blob/master/blip-0032.md | ||
| Blip32, | ||
| /// Resolve names locally using a specific DNS server. | ||
| Dns { | ||
| /// The IP and port of the DNS server. | ||
| /// | ||
| /// **Default:** `8.8.8.8:53` (Google Public DNS) | ||
| dns_server_address: SocketAddress, | ||
| /// If set to true, this allows others to use our node for HRN resolutions. | ||
| /// | ||
| /// **Default:** `false` | ||
| /// | ||
| /// **Note:** Enabling `enable_hrn_resolution_service` allows your node to act | ||
| /// as a resolver for the rest of the network. For this to work, your node must | ||
| /// be announceable (publicly visible in the network graph) so that other nodes | ||
| /// can route resolution requests to you via Onion Messages. This does not affect | ||
| /// your node's ability to resolve names for its own outgoing payments. | ||
| enable_hrn_resolution_service: bool, | ||
| }, | ||
| } | ||
|
|
||
| /// Configuration options for Human-Readable Names ([BIP 353]). | ||
| /// | ||
| /// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki | ||
| #[derive(Debug, Clone)] | ||
| #[cfg_attr(feature = "uniffi", derive(uniffi::Record))] | ||
| pub struct HumanReadableNamesConfig { | ||
| /// This sets how our node resolves names when we want to send a payment. | ||
| /// | ||
| /// By default, this uses the `Dns` variant with the following settings: | ||
| /// * **DNS Server**: `8.8.8.8:53` (Google Public DNS) | ||
| /// * **Resolution Service**: Enabled (`false`) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| pub resolution_config: HRNResolverConfig, | ||
| } | ||
|
|
||
| impl Default for HumanReadableNamesConfig { | ||
| fn default() -> Self { | ||
| HumanReadableNamesConfig { | ||
| resolution_config: HRNResolverConfig::Dns { | ||
| dns_server_address: SocketAddress::from_str("8.8.8.8:53") | ||
| .expect("Socket address conversion failed."), | ||
| enable_hrn_resolution_service: false, | ||
| }, | ||
| } | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This mentions
HumanReadableNamesConfig::default()which doesn't actually exist as it doesn't implementDefault. Also, please align the table columns again.