Custom attributes support in Avatar#5495
Open
Darshak03 wants to merge 1 commit intolivekit:mainfrom
Open
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Darshak03
force-pushed
the
Darshak03/custom-attributes-in-avatar
branch
from
1c3e0cb to
2c32466
Compare
Darshak03
force-pushed
the
Darshak03/custom-attributes-in-avatar
branch
from
2c32466 to
7f9a2e8
Compare
Member
|
I’m wondering if this is necessary, since you can directly use the agent participant’s attributes instead of the avatar’s? |
longcw
reviewed
Apr 27, 2026
| .with_name(self._avatar_participant_name) | ||
| .with_grants(api.VideoGrants(room_join=True, room=room.name)) | ||
| # allow the avatar agent to publish audio and video on behalf of your local agent | ||
| .with_attributes({ATTRIBUTE_PUBLISH_ON_BEHALF: local_participant_identity}) |
Contributor
There was a problem hiding this comment.
I don't think we should allow customizing this attribute, internally we are using this attribute the detect if a participant is representing another participant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.