diff --git a/layers/eight_mile/downloads.py b/layers/eight_mile/downloads.py index 16757c054..48361b33e 100644 --- a/layers/eight_mile/downloads.py +++ b/layers/eight_mile/downloads.py @@ -60,7 +60,26 @@ def extract_tar(file_loc): import tarfile temp_file = delete_old_copy("{}.1".format(file_loc)) with tarfile.open(file_loc, "r") as tar_ref: - tar_ref.extractall(temp_file) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_ref, temp_file) if len(os.listdir(temp_file)) != 1: raise RuntimeError("tar extraction unsuccessful") return os.path.join(temp_file, os.listdir(temp_file)[0])