Skip to content

Naturalcandy noli/placeholder#241

Closed
chhwang wants to merge 110 commits into
mainfrom
naturalcandy-noli/placeholder
Closed

Naturalcandy noli/placeholder#241
chhwang wants to merge 110 commits into
mainfrom
naturalcandy-noli/placeholder

Conversation

@chhwang

@chhwang chhwang commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

No description provided.

chhwang and others added 30 commits May 27, 2024 04:35
- Introduced support for multiple Runtime instances
- Added utility functions for multi-runtime management
- Ensured backward compatibility with existing usage patterns of Runtime
- Added unit tests for multi-runtime functionality

---------

Co-authored-by: noli <t-ngerawork@microsoft.com>
- Adds Torch to ARK tensor conversion support
- New ModelBufferManager class handles external buffer registration and
simplifies buffer access during kernel initialization
- Adds test cases for ARK to Torch conversion support

---------

Co-authored-by: Changho Hwang <changhohwang@microsoft.com>
@chhwang chhwang changed the base branch from main to chhwang/placeholder August 15, 2024 12:10
Base automatically changed from chhwang/placeholder to chhwang/torch August 19, 2024 04:03
@chhwang chhwang force-pushed the chhwang/torch branch 3 times, most recently from 2069f08 to e87f96b Compare January 23, 2025 23:35
Base automatically changed from chhwang/torch to main April 2, 2026 05:23
chhwang added a commit that referenced this pull request Jun 12, 2026
Add `arkprof` console-script entry point

Extract the `if __name__ == "__main__"` block in `profiler.py` into a
callable `main(argv=None)` function and register it as a
`[project.scripts]` console entry point in `pyproject.toml`:

    arkprof = "ark.profiler:main"

After `pip install`, `arkprof --plan <file>` invokes the profiler CLI.

Changes:
- `python/ark/profiler.py`: move argparse logic into `main(argv=None)`;
  accept optional argv for testability; strip whitespace in
  `--target_processor_groups` parsing; `__main__` guard delegates to
  `main()`.
- `pyproject.toml`: add `[project.scripts]` section.
- `python/unittest/test_profiler.py`: add 5 CLI/unit tests — `--help`
  exit code, missing `--plan` exit code, full arg parsing, defaults,
  and whitespace handling in `--target_processor_groups`. All tests use
  mocks (no GPU required).

Source: PR #241 (`arkprof.py`).
@chhwang

chhwang commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Superseded. The placeholder op + external-buffer binding already landed on main; the arkprof profiler entry point landed as a console script in #260. Closing as fully incorporated.

@chhwang chhwang closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants