Skip to content

Bugfix - Fix DeepSpeed BF16 config validation error #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polarG wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bugfix - Fix DeepSpeed BF16 config validation error #796

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
367cf62
Fix DeepSpeed BF16 config validation error by removing FP16-only loss…
Mar 26, 2026
5233926
Merge branch 'main' into dev/hongtaozhang/fix-deepspeed-bf16-config-v…
polarG Apr 27, 2026
d3baec9
Address PR review: clarify deepspeed config template comment
Apr 27, 2026
1587335
test: add deepspeed config schema regression test for fp16/bf16/fp32
May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions superbench/benchmarks/model_benchmarks/megatron_gpt3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,15 +307,23 @@ def __prepare_deespeed_config(self, precision_megatron):
"""Prepare deepspeed configs."""
self._config_json_path = os.path.join(self._args.data_home, 'ds_config_gpt.json')
# Load deepspeed config template json file
Comment thread
polarG marked this conversation as resolved.
Outdated
precision_template = {
'enabled': True,
'loss_scale': 0,
'loss_scale_window': 500,
'min_loss_scale': 1,
'initial_scale_power': 11
}
if self._args.hysteresis is not None:
precision_template['hysteresis'] = self._args.hysteresis
# FP16 supports loss scaling parameters; BF16 does not (sufficient dynamic range).
if precision_megatron == 'fp16':
precision_template = {
'enabled': True,
'loss_scale': 0,
'loss_scale_window': 500,
'min_loss_scale': 1,
'initial_scale_power': 11
}
if self._args.hysteresis is not None:
precision_template['hysteresis'] = self._args.hysteresis
elif precision_megatron == 'bf16':
precision_template = {
'enabled': True,
}
else:
precision_template = None

ds_config_template = {
'train_batch_size': self._args.batch_size,
Expand All @@ -328,7 +336,7 @@ def __prepare_deespeed_config(self, precision_megatron):
'prescale_gradients': self._args.prescale_grad,
}

if len(precision_megatron) > 0:
if precision_template is not None:
ds_config_template[precision_megatron] = precision_template
Comment thread
polarG marked this conversation as resolved.

# Write to config json file
Expand Down
Loading