Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new “Service URL Validation” documentation to the Teams SDK docs site, using the repo’s LanguageInclude system to provide per-language configuration examples.
Changes:
- New template page describing service URL allowlisting, custom domains, disablement, and proactive messaging guidance.
- New TypeScript/Python/C# include fragments for “adding custom domains” and “disabling validation” examples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| teams.md/src/pages/templates/essentials/service-url-validation.mdx | New Essentials page explaining service URL validation behavior and defaults. |
| teams.md/src/components/include/essentials/service-url-validation/typescript.incl.md | TS snippets for adding domains / disabling validation. |
| teams.md/src/components/include/essentials/service-url-validation/python.incl.md | Python snippets for adding domains / disabling validation. |
| teams.md/src/components/include/essentials/service-url-validation/csharp.incl.md | C# snippets (plus appsettings.json example) for adding domains / disabling validation. |
08da931 to
3744126
Compare
heyitsaamir
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation for security hardening changes shipping in the SDK PRs:
New page: Service URL Validation
src/pages/templates/essentials/service-url-validation.mdx+ per-language include filesDocuments the service URL domain allowlist:
additionalAllowedDomains*Test plan