Skip to content

Add VCPKG_TARGET_IS_BSD and VCPKG_HOST_IS_BSD#47309

Merged
BillyONeal merged 2 commits into
microsoft:masterfrom
cqundefine:generic_bsd_macros
Sep 30, 2025
Merged

Add VCPKG_TARGET_IS_BSD and VCPKG_HOST_IS_BSD#47309
BillyONeal merged 2 commits into
microsoft:masterfrom
cqundefine:generic_bsd_macros

Conversation

@cqundefine

Copy link
Copy Markdown
Contributor

In most places where there's a check for either FreeBSD or OpenBSD we probably want to be checking for BSD in general and this will make adding support for systems like NetBSD or DragonFly easier.

@dg0yt

dg0yt commented Sep 12, 2025

Copy link
Copy Markdown
Contributor
  • I'm not sure it is worth rebuilding libiconv and openssl now for all triplets and users.
    (The new variable could be adopted with regular port updates.)
  • IMO this variable should be complemented by a similar platform experession (bsd). This requires changes to the tool.

@cqundefine

Copy link
Copy Markdown
Contributor Author

I'm not sure it is worth rebuilding libiconv and openssl now for all triplets and users.

Yeah for now I reverted the changes, although I left those in the scripts that wouldn't cause any port updates.

IMO this variable should be complemented by a similar platform experession (bsd). This requires changes to the tool.

I've wanted to submit the tool PR once this one gets merged, though I've submitted one now.

@cqundefine

Copy link
Copy Markdown
Contributor Author

I can't see how those changes could cause CI failures especially on Windows/UWP, any idea what could be causing this?

@dg0yt

dg0yt commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Your changes to the make scripts cause rebuilds which expose the current set of baseline regressions. The baseline regressions are from this week's image updates.

You probably shouldn't update the legacy make scripts in scripts. All improvements shall go to the vcpkg-make port.

@BillyONeal

Copy link
Copy Markdown
Member

Close and reopen to pick up #47363

@BillyONeal BillyONeal added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Sep 16, 2025
BillyONeal
BillyONeal previously approved these changes Sep 16, 2025
@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 16, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) September 16, 2025 06:29
@BillyONeal

Copy link
Copy Markdown
Member

Thanks and sorry for confusion over the baseline issues.

@cqundefine

Copy link
Copy Markdown
Contributor Author

@BillyONeal could you take a look at this OS X failure, because I'm pretty sure it's also not related to this PR

@BillyONeal BillyONeal closed this Sep 22, 2025
auto-merge was automatically disabled September 22, 2025 23:40

Pull request was closed

@BillyONeal BillyONeal reopened this Sep 22, 2025
@BillyONeal BillyONeal closed this Sep 24, 2025
@BillyONeal BillyONeal reopened this Sep 24, 2025
@BillyONeal

Copy link
Copy Markdown
Member

Closed and reopened to pick up #47326 (I'm deleting all the old macOS boxes)

In most places where there's a check for either FreeBSD or OpenBSD we
probably want to be checking for BSD in general and this will make
adding support for systems like NetBSD or DragonFly easier.
@BillyONeal

Copy link
Copy Markdown
Member

The build failure is identical to most recent full build ( https://dev.azure.com/vcpkg/public/_build/results?buildId=120541&view=results )

@BillyONeal BillyONeal merged commit 4927a24 into microsoft:master Sep 30, 2025
15 of 18 checks passed
@cqundefine cqundefine deleted the generic_bsd_macros branch November 14, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants