diff --git a/pymilvus/client/bloom_filter.py b/pymilvus/client/bloom_filter.py index 9743aca7b..29240effd 100644 --- a/pymilvus/client/bloom_filter.py +++ b/pymilvus/client/bloom_filter.py @@ -464,7 +464,7 @@ def build(self) -> bytes: def build_bloom_filter(members: Sequence[Union[int, str]], fpr: float = _DEFAULT_FPR) -> bytes: - """Build an MBF1-wrapped Parquet Split-Block Bloom filter for bloom_match. + """Build an MBF1-wrapped Parquet Split-Block Bloom filter for membership_match. Integer members target INT8/INT16/INT32/INT64 fields; string members target VARCHAR fields. The returned bytes are passed through ``filter_params``. diff --git a/pymilvus/client/roaring_filter.py b/pymilvus/client/roaring_filter.py index bdc43e89e..b30aa7e9a 100644 --- a/pymilvus/client/roaring_filter.py +++ b/pymilvus/client/roaring_filter.py @@ -430,7 +430,7 @@ class RoaringBitmapBuilder: builder.add_int64_batch(chunk) blob = builder.build() - Build the bitmap from the SAME value domain as the target field: ``roaring_match`` matches + Build the bitmap from the SAME value domain as the target field: ``membership_match`` matches INT8/INT16/INT32/INT64 fields, and a narrow member is sign-extended, so ``INT8(-1)`` and ``-1`` are the same member. """ @@ -519,7 +519,7 @@ def build(self) -> bytes: def build_roaring_bitmap(members: Sequence[int]) -> bytes: - """Build an MRB1-wrapped portable Roaring64 bitmap for roaring_match. + """Build an MRB1-wrapped portable Roaring64 bitmap for membership_match. Members are signed integers targeting an INT8/INT16/INT32/INT64 field, in any order and with any number of duplicates. The returned bytes are passed through ``filter_params``, and are diff --git a/tests/unit/test_roaring_filter.py b/tests/unit/test_roaring_filter.py index 587f54454..6884d82ca 100644 --- a/tests/unit/test_roaring_filter.py +++ b/tests/unit/test_roaring_filter.py @@ -812,7 +812,7 @@ def test_roaring_blob_reaches_the_wire_through_the_public_client(mock_grpc_handl parsing; that happens after the request is sent, and the request is what is under test here. """ blob = build_roaring_bitmap([1, -1, 1 << 40]) - expr = "roaring_match(id, {rb})" + expr = "membership_match(id, {rb})" with patch("pymilvus.orm.connections.GrpcHandler", return_value=mock_grpc_handler), patch( "pymilvus.client.grpc_handler.GrpcHandler", return_value=mock_grpc_handler @@ -848,7 +848,7 @@ def test_roaring_blob_reaches_the_wire_through_the_public_client(mock_grpc_handl def test_roaring_blob_reaches_query_search_and_delete_requests(): """The blob must arrive as protobuf bytes -- not base64, not a string -- on every path.""" blob = build_roaring_bitmap([1, -1, 1 << 40]) - expr = "roaring_match(id, {rb})" + expr = "membership_match(id, {rb})" query = Prepare.query_request("coll", expr, [], None, expr_params={"rb": blob}) delete = Prepare.delete_request("coll", expr, None, 0, expr_params={"rb": blob})