Skip to content

Expose nuclear norm order in linalg API#411

Open
RNT56 wants to merge 1 commit into
ml-explore:mainfrom
RNT56:upstream-pr/linalg-norm-kind-nuc
Open

Expose nuclear norm order in linalg API#411
RNT56 wants to merge 1 commit into
ml-explore:mainfrom
RNT56:upstream-pr/linalg-norm-kind-nuc

Conversation

@RNT56
Copy link
Copy Markdown

@RNT56 RNT56 commented May 18, 2026

Summary

Expose the nuclear norm order through the Swift linalg API and documentation.

Validation

  • swift test --filter Linalg builds successfully, then aborts during runtime test startup because this upstream-based SwiftPM checkout cannot load default.metallib.

Copy link
Copy Markdown
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy, thanks!

@davidkoski
Copy link
Copy Markdown
Collaborator

Is this one ready? Still in draft. CI was broken at the point where you branched this -- if you rebase I will be able to run CI. Thanks!

@RNT56 RNT56 force-pushed the upstream-pr/linalg-norm-kind-nuc branch from 6c29f6f to d174d2d Compare May 23, 2026 15:45
@RNT56 RNT56 marked this pull request as ready for review May 23, 2026 15:46
@RNT56
Copy link
Copy Markdown
Author

RNT56 commented May 23, 2026

Rebased onto current upstream main (058eda6). The PR branch remains a single small linalg API/docs commit, now at d174d2d.

Local validation:

  • swift test --filter Linalg builds successfully.
  • Runtime startup still aborts locally because this SwiftPM checkout cannot load default.metallib:
    MLX error: Failed to load the default metallib. library not found ... Source/Cmlx/mlx-c/mlx/c/stream.cpp:115

The previous GitHub Actions failure on the old branch head was in mac_build_and_test before package compilation: the runner could not locate /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk. The lint, docs, and Linux build jobs passed there. This branch should now be ready for upstream CI to rerun against the current base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants