PYTHON-5760 Increase _azure_helpers.py coverage#2747
Open
aclark4life wants to merge 2 commits intomongodb:masterfrom
Open
PYTHON-5760 Increase _azure_helpers.py coverage#2747aclark4life wants to merge 2 commits intomongodb:masterfrom
aclark4life wants to merge 2 commits intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds focused unit coverage for PyMongo’s internal Azure IMDS helper (pymongo/_azure_helpers.py) by introducing a new test module that mocks urllib.request.urlopen, avoiding any dependency on a live Azure IMDS endpoint.
Changes:
- Added
test/test_azure_helpers.pywith success-path and error-path tests for_get_azure_response. - Verifies URL construction (resource, api-version, optional client_id), required headers, timeout propagation, and expected
ValueErrormessages on failure modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5760
Changes in this PR
Added test/test_azure_helpers.py
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer