Skip to content

fix: prevent funbox reactivation during page transition to leaderboards (@d1rshan) #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d1rshan wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −2
Open

fix: prevent funbox reactivation during page transition to leaderboards (@d1rshan) #7871

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d3fbd7
fix(funbox): avoid reinitializing funboxes on test page exit (@d1rshan)
d1rshan Apr 26, 2026
a486309
Merge branch 'master' into fix/funbox-reinit
d1rshan May 1, 2026
bedb09b
better fix
d1rshan May 2, 2026
ee325a7
tidy
d1rshan May 2, 2026
484e43e
Merge branch 'master' into fix/funbox-reinit
d1rshan May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/ts/pages/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const page = new Page({
afterHide: async (): Promise<void> => {
TestLogic.restart({
noAnim: true,
skipInit: true,
});
void Funbox.clear();
void ModesNotice.update();
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/ts/test/test-logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ type RestartOptions = {
practiseMissed?: boolean;
noAnim?: boolean;
isQuickRestart?: boolean;
skipInit?: boolean;
};

export function restart(options = {} as RestartOptions): void {
Expand All @@ -184,6 +185,7 @@ export function restart(options = {} as RestartOptions): void {
noAnim: false,
nosave: false,
isQuickRestart: false,
skipInit: false,
};

options = { ...defaultOptions, ...options };
Expand Down Expand Up @@ -353,6 +355,12 @@ export function restart(options = {} as RestartOptions): void {
TestState.setPaceRepeat(repeatWithPace);
TestInitFailed.hide();
TestState.setTestInitSuccess(true);

if (options.skipInit) {
TestState.setTestRestarting(false);
return;
}
Comment thread
d1rshan marked this conversation as resolved.
Outdated

const initResult = await init();

if (!initResult) {
Expand Down
Loading