Skip to content

Fix Dockerfile formatting and command order #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mosfet80 wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −4
Open

Fix Dockerfile formatting and command order #3735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37d707b
Fix Dockerfile formatting and command order
mosfet80 May 23, 2026
3d5e989
Update Dockerfile
mosfet80 May 23, 2026
8240781
Update Dockerfile
mosfet80 May 23, 2026
659f357
Update Dockerfile
mosfet80 May 23, 2026
c3200b3
Fix rosdep update order in Dockerfile
mosfet80 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/ci-testing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ RUN \
if [ -r src/moveit2/moveit2_"$ROS_DISTRO".repos ] ; then vcs import src < src/moveit2/moveit2_"$ROS_DISTRO".repos ; fi && \
#
# Download all dependencies of MoveIt
rosdep update && \
DEBIAN_FRONTEND=noninteractive \
rosdep install -y --from-paths src --ignore-src --rosdistro "$ROS_DISTRO" --as-root=apt:false && \
rosdep update && \
# Remove the source code from this container
rm -rf src && \
#
Expand Down
2 changes: 1 addition & 1 deletion .docker/ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

ARG ROS_DISTRO=rolling
FROM ros:${ROS_DISTRO}-ros-base
LABEL maintainer Robert Haschke rhaschke@techfak.uni-bielefeld.de

Check warning on line 6 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (rolling)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

ENV TERM xterm

Check warning on line 8 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (rolling)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Setup (temporary) ROS workspace
WORKDIR /root/ws_moveit
Expand All @@ -15,7 +15,7 @@

# Commands are combined in single RUN statement with "apt/lists" folder removal to reduce image size
# https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers
RUN \

Check failure on line 18 in .docker/ci/Dockerfile

View workflow job for this annotation

GitHub Actions / Lint Dockerfiles (ci) 

SC2086 info: Double quote to prevent globbing and word splitting.
# Update apt package list as previous containers clear the cache
apt-get -q update && \
apt-get -q -y upgrade && \
Expand All @@ -37,9 +37,9 @@
if [ -r src/moveit2/moveit2_${ROS_DISTRO}.repos ] ; then vcs import src < src/moveit2/moveit2_${ROS_DISTRO}.repos ; fi && \
#
# Download all dependencies of MoveIt
rosdep update && \
DEBIAN_FRONTEND=noninteractive \
rosdep install -y --from-paths src --ignore-src --rosdistro ${ROS_DISTRO} --as-root=apt:false && \
rosdep update && \
# Remove the source code from this container
rm -rf src && \
#
Expand Down
2 changes: 1 addition & 1 deletion .docker/source/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# Commands are combined in single RUN statement with "apt/lists" folder removal to reduce image size
# https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#minimize-the-number-of-layers
RUN --mount=type=cache,target=/root/.ccache/ \

Check failure on line 19 in .docker/source/Dockerfile

View workflow job for this annotation

GitHub Actions / Lint Dockerfiles (source) 

SC2086 info: Double quote to prevent globbing and word splitting.
# Enable ccache
PATH=/usr/lib/ccache:$PATH && \
# Fetch required upstream sources for building
Expand All @@ -26,9 +26,9 @@
. "/opt/ros/${ROS_DISTRO}/setup.sh" &&\
# Install dependencies from rosdep
apt-get -q update && \
rosdep update && \
DEBIAN_FRONTEND=noninteractive \
rosdep install -y --from-paths src --ignore-src --rosdistro ${ROS_DISTRO} --as-root=apt:false && \
rosdep update && \
rm -rf /var/lib/apt/lists/* && \
# Build the workspace
colcon build \
Expand Down
2 changes: 1 addition & 1 deletion .docker/tutorial-source/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ RUN --mount=type=cache,target=/root/.ccache/,sharing=locked \
. "/opt/ros/${ROS_DISTRO}/setup.sh" &&\
# Install dependencies from rosdep
apt-get -q update && \
rosdep update && \
DEBIAN_FRONTEND=noninteractive \
rosdep install -y --from-paths src --ignore-src --rosdistro ${ROS_DISTRO} --as-root=apt:false && \
rosdep update && \
rm -rf /var/lib/apt/lists/* && \
# Build the workspace
colcon build \
Expand Down
Loading