Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 686fdbe

Browse files
keianhzobluemarvin
authored andcommitted
Fixes private mode and bookmarks dimming issues (#1671)
1 parent 13c32ec commit 686fdbe

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
9696
boolean mActive = false;
9797
boolean mHovered = false;
9898
boolean mClickedAfterFocus = false;
99+
boolean mIsBookmarksVisible = false;
99100

100101
public interface WindowDelegate {
101102
void onFocusRequest(@NonNull WindowWidget aWindow);
@@ -281,11 +282,13 @@ public void switchBookmarks() {
281282
setView(mBookmarksView);
282283
for (BookmarkListener listener : mBookmarksListeners)
283284
listener.onBookmarksShown(this);
285+
mIsBookmarksVisible = true;
284286

285287
} else {
286288
unsetView(mBookmarksView);
287289
for (BookmarkListener listener : mBookmarksListeners)
288290
listener.onBookmarksHidden(this);
291+
mIsBookmarksVisible = false;
289292
}
290293

291294
updateTitleBar();
@@ -684,6 +687,17 @@ public void setVisible(boolean aVisible) {
684687
return;
685688
}
686689
mWidgetPlacement.visible = aVisible;
690+
if (!aVisible) {
691+
if (mIsBookmarksVisible) {
692+
mWidgetManager.popWorldBrightness(this);
693+
}
694+
695+
} else {
696+
if (mIsBookmarksVisible) {
697+
mWidgetManager.pushWorldBrightness(this, WidgetManagerDelegate.DEFAULT_DIM_BRIGHTNESS);
698+
}
699+
}
700+
mIsBookmarksVisible = isBookmarksVisible();
687701
mWidgetManager.updateWidget(this);
688702
if (!aVisible) {
689703
clearFocus();

0 commit comments

Comments
 (0)