Fixes not updating the private browsing mode tooltip (#1555)

keianhzo · bluemarvin · commit 8437d6ea832e · 2019-08-09T16:05:21.000-07:00
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/TrayWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/TrayWidget.java
@@ -305,13 +305,13 @@ private void handleSessionState() {
                 if (isPrivateMode) {
                     mWidgetManager.pushWorldBrightness(this, WidgetManagerDelegate.DEFAULT_DIM_BRIGHTNESS);
                     mPrivateButton.setImageResource(R.drawable.ic_icon_tray_private_browsing_on_v2);
-                mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_exit_tooltip));
+                    mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_exit_tooltip));
 
                 } else {
                     mWidgetManager.popWorldBrightness(this);
                     mPrivateButton.setImageResource(R.drawable.ic_icon_tray_private_browsing_v2);
+                    mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_enter_tooltip));
                 }
-                mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_enter_tooltip));
             }
 
             mIsLastSessionPrivate = isPrivateMode;

Original file line number	Diff line number	Diff line change
`@@ -305,13 +305,13 @@ private void handleSessionState() {`
`305`	`305`	`if (isPrivateMode) {`
`306`	`306`	`mWidgetManager.pushWorldBrightness(this, WidgetManagerDelegate.DEFAULT_DIM_BRIGHTNESS);`
`307`	`307`	`mPrivateButton.setImageResource(R.drawable.ic_icon_tray_private_browsing_on_v2);`
`308`		`- mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_exit_tooltip));`
	`308`	`+ mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_exit_tooltip));`
`309`	`309`
`310`	`310`	`} else {`
`311`	`311`	`mWidgetManager.popWorldBrightness(this);`
`312`	`312`	`mPrivateButton.setImageResource(R.drawable.ic_icon_tray_private_browsing_v2);`
	`313`	`+ mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_enter_tooltip));`
`313`	`314`	`}`
`314`		`- mPrivateButton.setTooltip(getResources().getString(R.string.private_browsing_enter_tooltip));`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`mIsLastSessionPrivate = isPrivateMode;`