This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Remove camera permission in Oculus Go and Quest builds#1348
Merged
Conversation
MortimerGoro
approved these changes
Jun 27, 2019
keianhzo
force-pushed
the
camera_permission_occulus
branch
2 times, most recently
from
9a17d99 to
5c271e0
Compare
Remove camera from privacy for oculus wip wip
keianhzo
force-pushed
the
camera_permission_occulus
branch
from
5c271e0 to
26ff600
Compare
Contributor
|
I see the black screen on the Go. Asking if we can do anything in GV to prevent it. |
Contributor
|
Wasn't a GeckoView issue. But it turns out we already had to fix this for Wave. I added the fix to oculusvr so we won't get a flash. |
bluemarvin
approved these changes
Jun 27, 2019
Contributor
Author
|
@bluemarvin Works fine for the camera permission but still flickers for any other permissions. As it seems Android doesn't offer an API to check if a permission has been blocked before requesting it, I'll land this and file a bug to address this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1345 Added a tag in the Oculus manifest to remove inherited camera permission from the parent manifest. Also removed it from the Privacy options just for oculus builds.