This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Transfrom controller pitch angle to match Focus controllers in system.#1363
Merged
Conversation
Contributor
Author
|
I can't find a way to get their system version to decide if we need to make this change on their previous system. I might need to get assistance from the partner. |
bluemarvin
suggested changes
Jul 3, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
We either need to get the updated model off of the device or apply this transform to the model directly. We shouldnot be applying this transform twice every frame.
Contributor
That's probably fine. I doubt there will be very many people running the old system. |
daoshengmu
force-pushed
the
adjustFocusControllerTransform
branch
from
09847d7 to
8d9a52c
Compare
bluemarvin
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #1354, we want to make Focus Plus controller's position match the controllers in system.