Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Do not resize fullscreen window size if the window size is actually larger than the threshold.#1379

Merged
bluemarvin merged 1 commit into
masterfrom
fullscreen_smaller_issue
Jul 22, 2019
Merged

Do not resize fullscreen window size if the window size is actually larger than the threshold.#1379
bluemarvin merged 1 commit into
masterfrom
fullscreen_smaller_issue

Conversation

@MortimerGoro

Copy link
Copy Markdown
Contributor

Fixes #1362

@MortimerGoro MortimerGoro force-pushed the fullscreen_smaller_issue branch from 38587ff to 8ebffd4 Compare July 9, 2019 11:45
@bluemarvin

Copy link
Copy Markdown
Contributor

I'm confused what the issue is and what the expected behavior should be. I feel like there should be two screen sizes. One for normal browsing and one for full screen. But is seems to me that no mater what size I set for the full screen window, it reverts to the standard window size next time? I also could not reproduce the clipping described in the STR for the issue. Am I missing a step?

@MortimerGoro

MortimerGoro commented Jul 11, 2019

Copy link
Copy Markdown
Contributor Author

I also see a problem outside of the Hubs layout issue. STR:

Isn't it weird that fullscreen reduces the actual window size? If a user wants a youtube fullscreen video at 3X he can't because of this resize.

cc @jvonitter This may require design decision.

@bluemarvin

Copy link
Copy Markdown
Contributor

I agree that our window sizing is confusing. It rarely behaves the way I would expect and doesn't seem to retain the size I set it to.

@jvonitter

Copy link
Copy Markdown
Contributor

thanks for the heads up @MortimerGoro . I'll check in with UX about it

@thenadj

thenadj commented Jul 11, 2019

Copy link
Copy Markdown

Looking at it and need some time to reply... expect answers early next week.

@jvonitter

Copy link
Copy Markdown
Contributor

@thenadj and I just discussed this and we think you're right, sizing the screen down like that is weird. What we'd like to do is update the logic to be:
If you enter full screen with a view that is 1.75x or smaller, it enlarges to 1.75x.
Anything bigger than that size doesn't change size.

Sound ok?

@philip-lamb philip-lamb added this to the v1.4 milestone Jul 12, 2019
@MortimerGoro

Copy link
Copy Markdown
Contributor Author
I just discussed this and we think you're right, sizing the screen down like that is weird. 
What we'd like to do is update the logic to be:
If you enter full screen with a view that is 1.75x or smaller, it enlarges to 1.75x.
Anything bigger than that size doesn't change size.

Thanks! that logic is what the PR is supposed to do.

@MortimerGoro MortimerGoro force-pushed the fullscreen_smaller_issue branch from 8ebffd4 to ddc1473 Compare July 12, 2019 08:23
@MortimerGoro MortimerGoro self-assigned this Jul 16, 2019
…igger than the fullscreen min size threshold
@MortimerGoro MortimerGoro force-pushed the fullscreen_smaller_issue branch from ddc1473 to 7f05ab5 Compare July 22, 2019 15:11
@bluemarvin bluemarvin merged commit b19f56b into master Jul 22, 2019
@bluemarvin bluemarvin deleted the fullscreen_smaller_issue branch July 23, 2019 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full screen transitions in Hubs do not work as expected

6 participants