This repository was archived by the owner on Jul 22, 2024. It is now read-only.
If resize is cancelled, resize back to the screen size it had before entering resize mode.#1411
Merged
Conversation
…entering resize mode
MortimerGoro
force-pushed
the
resize_back
branch
from
aa9dc78 to
78089a0
Compare
keianhzo
approved these changes
Jul 18, 2019
bluemarvin
reviewed
Jul 19, 2019
|
|
||
| enum ResizeAction { | ||
| KEEP_SIZE, | ||
| RESTORE_SIZE |
Contributor
There was a problem hiding this comment.
Are we using enum now? Do they no longer bloat the APK? We are now using both enum and final int in different places. final int I guess makes sense for JNI calls. Not sure if there is a benefit to enum?
bluemarvin
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1391