This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add support for display/voice/content languages#1474
Merged
Conversation
bluemarvin
approved these changes
Jul 31, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
Looks okay to me other than a few nits. The new selection page is sort of ugly though. Feels like SOME ONE IS SCREAMING AT ME.
keianhzo
force-pushed
the
choose_languages
branch
from
aecaa0a to
75ad17a
Compare
Contributor
Author
|
@bluemarvin I think we could just not capitalize the language and just bold it. Also seeing it now I think it needs a new line so the language doesn't get cut when it's too long. I'll update with those changes. |
keianhzo
force-pushed
the
choose_languages
branch
from
e90b4f2 to
24b93e9
Compare
Contributor
Author
|
@bluemarvin @MortimerGoro I've updated with some changes. |
MortimerGoro
approved these changes
Aug 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #794 Added support for voice/display/content languages