This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Support for WaveVR appId #1476
Merged
Merged
Conversation
MortimerGoro
suggested changes
Jul 30, 2019
MortimerGoro
left a comment
MortimerGoro
left a comment
Contributor
There was a problem hiding this comment.
You also need to update https://github.com/MozillaReality/FirefoxReality/blob/master/tools/taskcluster/build_targets.py
Contributor
Author
|
@MortimerGoro updated! |
MortimerGoro
approved these changes
Jul 31, 2019
philip-lamb
reviewed
Aug 2, 2019
philip-lamb
reviewed
Aug 2, 2019
philip-lamb
approved these changes
Aug 2, 2019
This was referenced Dec 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1458 Added a .wavevr for non-store WaveVR builds so we can install debug and staging builds without clashing with the preinstalled app id.
Also replace noapi x86 builds with x86_64.