Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fixes non working reset for privacy settings#1506

Merged
bluemarvin merged 2 commits into
masterfrom
settings_fixes
Aug 6, 2019
Merged

Fixes non working reset for privacy settings#1506
bluemarvin merged 2 commits into
masterfrom
settings_fixes

Conversation

@keianhzo

@keianhzo keianhzo commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

The privacy settings were not being reset correctly.

@keianhzo keianhzo requested a review from bluemarvin August 5, 2019 20:58

@bluemarvin bluemarvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset button for Privacy and Security says Reset Display Settings
Screen_Shot_1908052653

@bluemarvin

Copy link
Copy Markdown
Contributor

Environment panel also say Reset Display Settings

@keianhzo

keianhzo commented Aug 6, 2019

Copy link
Copy Markdown
Contributor Author

Fixed reset buttons descriptions and moved out the override env button from the env scrollview.

@bluemarvin

Copy link
Copy Markdown
Contributor

I'm going to land this. If @MortimerGoro has any feedback it can be done in a follow up.

@bluemarvin bluemarvin merged commit 4cab6e4 into master Aug 6, 2019
@bluemarvin bluemarvin deleted the settings_fixes branch August 7, 2019 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants