This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Update SurfaceChanged callback target when a Surface is moved to a different layer#1540
Merged
Conversation
bluemarvin
approved these changes
Aug 8, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
I'm a little concerned about the maintainability of this code. Perhaps for 1.5 we can look at some refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536
The problems happens when the flat/curved switch is done to a widget that has never been rendered (e.g. the keyboard starts invisible). The layer waits to receive the first composite notification to allow rendering it. But when a surface is moved to a new layer (e.g. flat to curved) the old layer still receives the callback. This PR also prevents a potential crash if the callback is received after a layer is deallocated (it can happen due to UI and native render thread differences)