This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Do not make multi-windows visible if there is only one window#1675
Merged
Conversation
MortimerGoro
left a comment
MortimerGoro
left a comment
Contributor
There was a problem hiding this comment.
Related: Should we still show the close button for a single private window? We always had that feature before adding multiwindow. Close button erases al private sessions vs private button in the tray switches to regular but keeps private sessions alive.
Contributor
|
We definitely need a way to clear private browsing. That’s what the close button was originally for. |
Contributor
Author
|
I've updated the PR to also show the close button when resize is finished in private mode. |
bluemarvin
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1633 Do not make multi-windows visible if there is only one window