This repository was archived by the owner on Jul 22, 2024. It is now read-only.
System config changes fixes#2797
Merged
Merged
Conversation
Merged
bluemarvin
approved these changes
Feb 18, 2020
MortimerGoro
approved these changes
Feb 18, 2020
|
I have verified these new behaviors using the latest RC, Firefox Reality version 9 RC2 (37ac4cb), installed on the Oculus Go, Quest, HTC Vive Focus, Focus Plus and Pico Neo2 headsets. Everything seems to be working as expected. |
Softvision-GeluHaiduc
added
the
[QA]:Verified fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues that I've seen while testing v9 with language update from the system config. Fixes the correct update of the URL and Title bars.
Also fixes the correct update of app dialogs in case the system language is changed while a dialog is opened.