Closes #672 Downloads support#3072
Conversation
|
Seems pretty good. Not sure I like the badge. I also find the save location of internal or external confusing. I have no idea where that would be if I went looking for the files on the device if I were to mount it. |
|
Updated with final design: https://trello.com/c/iBLotKN4 |
|
Looks like the download icon is still missing? |
|
The spec also has the download progress like on desktop with a blue badge after download is complete. |
|
Not sure why you don't see them but both things you mentioned were already there in the last push. I've forced push again and fixed and issue I was seeing with clipping. |
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Download window fails to show if page creates a new tab. STR:
- go to https://community-tc.services.mozilla.com/tasks/Vl6vfgK4Ti6y9M1aMl65rQ#artifacts
- click on one of the APKs and start download
- click download button from tray
Actual:
Nothing happens
Expected:
Download window is opened.
keianhzo
force-pushed
the
v10/downloads
branch
2 times, most recently
from
94b584e to
939fcc3
Compare
|
@bluemarvin seems to be related to the firstpaint issue. |
Which first paint issue? Has it been fixed in master because I rebased and am still seeing the issue. |
|
@bluemarvin I didn't have time to fix the firstpaint issue today but what you see here it's related to that. You can also reproduce it if you open a new tab in the background from the context menu and switch to that tab. |
bluemarvin
force-pushed
the
v10/downloads
branch
from
19607bc to
273c691
Compare
2 participants
Closes #672 This PR adds Downloads support. Some refactoring has been done to take all the Library panels logic out from the Window class.
Waiting for final design.