Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Ensure mUri is not null in Window save#3279

Merged
keianhzo merged 1 commit into
masterfrom
save-crash
Apr 29, 2020
Merged

Ensure mUri is not null in Window save#3279
keianhzo merged 1 commit into
masterfrom
save-crash

Conversation

@bluemarvin

Copy link
Copy Markdown
Contributor

@bluemarvin bluemarvin added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Apr 28, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Apr 28, 2020
@bluemarvin bluemarvin requested a review from keianhzo April 28, 2020 23:38
@bluemarvin bluemarvin self-assigned this Apr 28, 2020
@bluemarvin bluemarvin changed the title Ensure mUri is not null Window save Ensure mUri is not null in Window save Apr 28, 2020

@keianhzo keianhzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing at the crash, looks like it must be that. Can we make it in a single line? like:

.filter(sessionState -> SAVE_BLACKLIST.stream().noneMatch(uri ->
                            sessionState.mUri == null || sessionState.mUri.startsWith(uri)))

@bluemarvin

Copy link
Copy Markdown
Contributor Author

Seeing at the crash, looks like it must be that. Can we make it in a single line? like:

.filter(sessionState -> SAVE_BLACKLIST.stream().noneMatch(uri ->
                            sessionState.mUri == null || sessionState.mUri.startsWith(uri)))

Shouldn't it be sessionState.mUri != null && sessionState.mUri.startsWith(uri)))

@keianhzo keianhzo merged commit 135a8ac into master Apr 29, 2020
@keianhzo keianhzo deleted the save-crash branch April 29, 2020 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants