Skip to content

[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade @testing-library/jest-dom from 5.11.9 to 5.17.0 #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 46 additions & 55 deletions 0x05-react_state/task_0/dashboard/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion 0x05-react_state/task_0/dashboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "",
"main": "index.js",
"dependencies": {
"@testing-library/jest-dom": "^5.11.9",
"@testing-library/jest-dom": "^5.17.0",

@gemini-code-assist gemini-code-assist Bot Feb 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade introduces a dependency conflict that will likely break your tests.

  • @testing-library/jest-dom@5.17.0 (this PR) depends on @testing-library/dom@^9.3.1.
  • Your project's @testing-library/react@11.2.5 depends on @testing-library/dom@^7.29.4.

Using multiple major versions of @testing-library/dom is unsupported and leads to errors. Your project is constrained to @testing-library/dom v7 because you are using React 16, which limits @testing-library/react to v11.

To fix this, I suggest upgrading to the latest version of @testing-library/jest-dom that is compatible with @testing-library/dom v7, which is 5.11.10.

As a further improvement, consider updating other testing libraries to their latest patch versions to maintain consistency:

  • @testing-library/react to ^11.2.7
  • @testing-library/user-event to ^12.8.3
Suggested change
"@testing-library/jest-dom": "^5.17.0",
"@testing-library/jest-dom": "^5.11.10",

"@testing-library/react": "^11.2.5",
"@testing-library/user-event": "^12.7.1",
"aphrodite": "^2.4.0",
Expand Down