Versions not showing up in nextcloud-releases

[Sp1l]

Looks like tags v4.6.0 and v4.7.0 are released, but they're missing in https://github.com/nextcloud-releases/twofactor_admin/releases

Could be that it's not ready, just checking.

[Sp1l]

ping @ChristophWurst

[ChristophWurst]

Dear @Sp1l thank you for your feedback. Looking at https://github.com/nextcloud/twofactor_admin/actions/workflows/release.yml it appears that the release automation runs have simply failed for 4.6.0 and 4.7.0. Each time the automation updated the changelog and created a tag in this repo, but no changes were sent to the fork nor did it release anything to the app store. I hope this explains the situation.

[Eloston]

@ChristophWurst Thanks for the clarification, but I think the underlying question is if 4.6.0 or 4.7.0 should have been released to the app store since they were developed months ago but not published, and there hasn't been new activity since.

Also, 4.7.0 is the first to support NC 30 which may be part of the original motivation (see #351).

[ChristophWurst]

Hi @Eloston! The releases should have been on the app store. This is a problem with the release automation, which failed.

[j-nicolas]

Hi @ChristophWurst , where could the release automation problem be addressed?

[ChristophWurst]

The release automation is part of this repo. Check the .github/workflows directory.

[j-nicolas]

No expert-opinion, just a blind trial:
release.yml has:

• uses: actions/checkout@v2 instead of uses: actions/checkout@v4
• uses: TriPSs/conventional-changelog-action@v3 instead of uses: TriPSs/conventional-changelog-action@v5
• uses: skjnldsv/read-package-engines-version-actions@v1.1 instead of uses: skjnldsv/read-package-engines-version-actions@v2
• uses: softprops/action-gh-release@v1 instead of uses: softprops/action-gh-release@v2

(and 2 others by nextcloud and yourself).

[ChristophWurst]

5e2c490 looks like it was supposed to fix the release automation.

[ChristophWurst]

Despite v4.7.0...main the conventional commit action says there are no changes:

Run TriPSs/conventional-changelog-action@v3
Using "angular" preset
Using "chore(release): {version} [skip ci]" as commit message
Using "Conventional Changelog Action" as git user.name
Using "conventional.changelog.action@github.com" as git user.email
Using "0" release count
Using "package.json, package-lock.json" as version file
Using "version" as version path
Using "v" as tag prefix
Using "CHANGELOG.md" as output file
Using "" as config file
Using "github.com" as gitUrl
Using "main" as gitBranch
Using "" as gitPath
Using "build/pre-commit.js" as pre-commit script
Skipping empty releases is "enabled"
Skipping the update of the version file is "disabled"
/usr/bin/git config user.name Conventional Changelog Action
/usr/bin/git config user.email conventional.changelog.action@github.com
/usr/bin/git remote set-url origin ***github.com/nextcloud/twofactor_admin.git
Recommended release type: patch
Because: There are 0 BREAKING CHANGES and 0 features
Files to bump: package.json, package-lock.json
Bumping version to file "package.json" with extension "json"
Bumping version to file "package-lock.json" with extension "json"
Bumped file "/home/runner/actions-runner/_work/twofactor_admin/twofactor_admin/package.json" from "4.7.0" to "4.7.1"
Bumped file "/home/runner/actions-runner/_work/twofactor_admin/twofactor_admin/package-lock.json" from "4.7.0" to "4.7.1"
Changelog generated
## [4.7.1](https://github.com/ChristophWurst/twofactor_admin/compare/v4.7.0...v4.7.1) (2024-10-25)

so 👍 on updating the action from v3 to v5.

[ChristophWurst]

What puzzles me is how the action does not see any of the Fix(l10n): ... commits. These should definitely result in a patch release.

[ChristophWurst]

29fe512 worked. I strongly believe it's that Fix commits are not picked up while fix are.

[ChristophWurst]

v4.7.1 released. It's also found on the releases org.

[Eloston]

Thanks @ChristophWurst for solving and publishing a new version!